Add Error::getMessageWithColumnInfo()

Author: nikic

bin/php-parse

@@ -90,11 +90,7 @@ foreach ($files as $file) {
 
 function formatErrorMessage(PhpParser\Error $e, $code, $withColumnInfo) {
     if ($withColumnInfo && $e->hasColumnInfo()) {
-        $startLine = $e->getStartLine();
-        $endLine = $e->getEndLine();
-        $startColumn = $e->getStartColumn($code);
-        $endColumn   = $e->getEndColumn($code);
-        return $e->getRawMessage() . " from $startLine:$startColumn to $endLine:$endColumn";
+        return $e->getMessageWithColumnInfo($code);
     } else {
         return $e->getMessage();
     }

lib/PhpParser/Error.php

@@ -120,6 +120,14 @@ public function getEndColumn($code) {
         return $this->toColumn($code, $this->attributes['endFilePos']);
     }
 
+    public function getMessageWithColumnInfo($code) {
+        return sprintf(
+            '%s from %d:%d to %d:%d', $this->getRawMessage(),
+            $this->getStartLine(), $this->getStartColumn($code),
+            $this->getEndLine(), $this->getEndColumn($code)
+        );
+    }
+
     private function toColumn($code, $pos) {
         if ($pos > strlen($code)) {
             throw new \RuntimeException('Invalid position information');

test/PhpParser/CodeParsingTest.php

@@ -60,8 +60,7 @@ public function provideTestParse() {
 
     private function formatErrorMessage(Error $e, $code) {
         if ($e->hasColumnInfo()) {
-            return $e->getRawMessage() . ' from ' . $e->getStartLine() . ':' . $e->getStartColumn($code)
-                . ' to ' . $e->getEndLine() . ':' . $e->getEndColumn($code);
+            return $e->getMessageWithColumnInfo($code);
         } else {
             return $e->getMessage();
         }