Skip to content

Commit 0df676e

Browse files
Fix CS/WS issues
1 parent 4df0bfc commit 0df676e

File tree

2 files changed

+21
-30
lines changed

2 files changed

+21
-30
lines changed

src/Differ.php

Lines changed: 19 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -81,25 +81,23 @@ public function __construct($header = "--- Original\n+++ New\n")
8181
public function diff($from, $to)
8282
{
8383
$buffer = $this->header;
84-
$diff = $this->diffToArray($from,$to);
84+
$diff = $this->diffToArray($from, $to);
8585

86-
$inOld = FALSE;
86+
$inOld = false;
8787
$i = 0;
8888
$old = array();
8989

9090
foreach ($diff as $line) {
9191
if ($line[1] === 0 /* OLD */) {
92-
if ($inOld === FALSE) {
92+
if ($inOld === false) {
9393
$inOld = $i;
9494
}
95-
}
96-
97-
else if ($inOld !== FALSE) {
95+
} elseif ($inOld !== false) {
9896
if (($i - $inOld) > 5) {
9997
$old[$inOld] = $i - 1;
10098
}
10199

102-
$inOld = FALSE;
100+
$inOld = false;
103101
}
104102

105103
++$i;
@@ -112,29 +110,25 @@ public function diff($from, $to)
112110
$end = $tmp;
113111
}
114112

115-
$newChunk = TRUE;
113+
$newChunk = true;
116114

117115
for ($i = $start; $i < $end; $i++) {
118116
if (isset($old[$i])) {
119117
$buffer .= "\n";
120-
$newChunk = TRUE;
118+
$newChunk = true;
121119
$i = $old[$i];
122120
}
123121

124122
if ($newChunk) {
125123
$buffer .= "@@ @@\n";
126-
$newChunk = FALSE;
124+
$newChunk = false;
127125
}
128126

129127
if ($diff[$i][1] === 1 /* ADDED */) {
130128
$buffer .= '+' . $diff[$i][0] . "\n";
131-
}
132-
133-
else if ($diff[$i][1] === 2 /* REMOVED */) {
129+
} elseif ($diff[$i][1] === 2 /* REMOVED */) {
134130
$buffer .= '-' . $diff[$i][0] . "\n";
135-
}
136-
137-
else {
131+
} else {
138132
$buffer .= ' ' . $diff[$i][0] . "\n";
139133
}
140134
}
@@ -197,7 +191,8 @@ public function diffToArray($from, $to)
197191
}
198192

199193
$common = $this->longestCommonSubsequence(
200-
array_values($from), array_values($to)
194+
array_values($from),
195+
array_values($to)
201196
);
202197

203198
$diff = array();
@@ -232,11 +227,11 @@ public function diffToArray($from, $to)
232227
array_shift($to);
233228
}
234229

235-
while (($token = array_shift($from)) !== NULL) {
230+
while (($token = array_shift($from)) !== null) {
236231
$diff[] = array($token, 2 /* REMOVED */);
237232
}
238233

239-
while (($token = array_shift($to)) !== NULL) {
234+
while (($token = array_shift($to)) !== null) {
240235
$diff[] = array($token, 1 /* ADDED */);
241236
}
242237

@@ -272,9 +267,9 @@ private function longestCommonSubsequence(array $from, array $to)
272267
for ($i = 1; $i <= $fromLength; ++$i) {
273268
for ($j = 1; $j <= $toLength; ++$j) {
274269
$matrix[$i][$j] = max(
275-
$matrix[$i-1][$j],
276-
$matrix[$i][$j-1],
277-
$from[$i-1] === $to[$j-1] ? $matrix[$i-1][$j-1] + 1 : 0
270+
$matrix[$i-1][$j],
271+
$matrix[$i][$j-1],
272+
$from[$i-1] === $to[$j-1] ? $matrix[$i-1][$j-1] + 1 : 0
278273
);
279274
}
280275
}
@@ -287,13 +282,9 @@ private function longestCommonSubsequence(array $from, array $to)
287282
array_unshift($common, $from[$i-1]);
288283
--$i;
289284
--$j;
290-
}
291-
292-
else if ($matrix[$i][$j-1] > $matrix[$i-1][$j]) {
285+
} elseif ($matrix[$i][$j-1] > $matrix[$i-1][$j]) {
293286
--$j;
294-
}
295-
296-
else {
287+
} else {
297288
--$i;
298289
}
299290
}

src/Parser.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,13 +119,13 @@ private function parseFileDiff(Diff $diff, array $lines)
119119

120120
while (count($lines) &&
121121
(preg_match('(^(?P<type>[+ -])?(?P<line>.*))', $last = array_shift($lines), $match) ||
122-
(strpos($last, '\\ No newline at end of file' ) === 0))) {
122+
(strpos($last, '\\ No newline at end of file') === 0))) {
123123
if (count($match)) {
124124
$type = Line::UNCHANGED;
125125

126126
if ($match['type'] == '+') {
127127
$type = Line::ADDED;
128-
} else if ($match['type'] == '-') {
128+
} elseif ($match['type'] == '-') {
129129
$type = Line::REMOVED;
130130
}
131131

0 commit comments

Comments
 (0)