Remove version 10

Author: nikic

README.md

@@ -482,9 +482,9 @@ Supported since 2015-10-21. Deprecated since 2016-04-30.
   `AST_PROP_ELEM`. This means that each property in one property declaration can have its own
   doc comment.
 
-### 10 (deprecated)
+### 10 (removed)
 
-Initial.
+Initial. Removed since 2016-08-04.
 
 Differences to PHP-Parser
 -------------------------

ast.c

@@ -536,22 +536,8 @@ static void ast_to_zval(zval *zv, zend_ast *ast, zend_long version) {
 		ast_update_property(zv, AST_STR(str_flags), &tmp_zv, AST_CACHE_SLOT_FLAGS);
 	}
 
-	if (version < 15 && ast->kind == ZEND_AST_PROP_DECL) {
-		/* Before version 15 the first docComment was stored on the PROP_DECL */
-		zend_ast_list *props = zend_ast_get_list(ast);
-		uint32_t i;
-		for (i = 0; i < props->children; ++i) {
-			zend_ast *prop = props->child[i];
-			if (prop->child[2]) {
-				ZVAL_STR_COPY(&tmp_zv, zend_ast_get_str(prop->child[2]));
-				ast_update_property(zv, AST_STR(str_docComment), &tmp_zv, NULL);
-				break;
-			}
-		}
-	}
-
 	/* Convert doc comments on properties and constants into properties */
-	if (version >= 15 && ast->kind == ZEND_AST_PROP_ELEM && ast->child[2]) {
+	if (ast->kind == ZEND_AST_PROP_ELEM && ast->child[2]) {
 		ZVAL_STR_COPY(&tmp_zv, zend_ast_get_str(ast->child[2]));
 		ast_update_property(zv, AST_STR(str_docComment), &tmp_zv, NULL);
 	}
@@ -568,7 +554,7 @@ static void ast_to_zval(zval *zv, zend_ast *ast, zend_long version) {
 	ast_fill_children_ht(Z_ARRVAL(tmp_zv), ast, version);
 }
 
-static const zend_long versions[] = {10, 15, 20, 30, 35, 40};
+static const zend_long versions[] = {15, 20, 30, 35, 40};
 static const size_t versions_count = sizeof(versions)/sizeof(versions[0]);
 
 static zend_string *ast_version_info() {
@@ -602,7 +588,7 @@ static int ast_check_version(zend_long version) {
 	zend_string *version_info;
 
 	if (ast_version_known(version)) {
-		if (version == 10 || version == 15 || version == 20) {
+		if (version == 15 || version == 20) {
 			php_error_docref(NULL, E_DEPRECATED,
 				"Version " ZEND_LONG_FMT " is deprecated", version);
 		}

tests/prop_doc_comments.phpt

@@ -20,35 +20,10 @@ class A {
 }
 PHP;
 
-echo ast_dump(ast\parse_code($code, $version=10)), "\n";
 echo ast_dump(ast\parse_code($code, $version=15)), "\n";
 
 ?>
 --EXPECTF--
-Deprecated: ast\parse_code(): Version 10 is deprecated in %s on line %d
-AST_STMT_LIST
-    0: AST_CLASS
-        flags: 0
-        name: A
-        0: null
-        1: null
-        2: AST_STMT_LIST
-            0: AST_PROP_DECL
-                flags: MODIFIER_PUBLIC (256)
-                docComment: /** docComment $a */
-                0: AST_PROP_ELEM
-                    0: "a"
-                    1: null
-            1: AST_PROP_DECL
-                flags: MODIFIER_PUBLIC (256)
-                docComment: /** docComment $b */
-                0: AST_PROP_ELEM
-                    0: "b"
-                    1: null
-                1: AST_PROP_ELEM
-                    0: "c"
-                    1: null
-
 Deprecated: ast\parse_code(): Version 15 is deprecated in %s on line %d
 AST_STMT_LIST
     0: AST_CLASS

tests/version_errors.phpt

@@ -17,5 +17,5 @@ try {
 
 ?>
 --EXPECTF--
-No version specified. Current version is %d. All versions (including experimental): {10, 15, 20, %s}
-Unknown version 100. Current version is %d. All versions (including experimental): {10, 15, 20, %s}
+No version specified. Current version is %d. All versions (including experimental): {15, 20, 30, %s}
+Unknown version 100. Current version is %d. All versions (including experimental): {15, 20, 30, %s}