Support php 8.0 named parameters (nikic#166)

https://wiki.php.net/rfc/named_params is accepted.
This works when built against the PR implementing that RFC.

Also, amend attributes so that tests pass on php 8.0-dev
(they will be amended again based on the planned vote)

Author: TysonAndre

README.md

@@ -412,6 +412,7 @@ AST_METHOD:           name, docComment, params, stmts, returnType, attributes
 AST_METHOD_CALL:      expr, method, args
 AST_METHOD_REFERENCE: class, method
 AST_NAME:             name
+AST_NAMED_ARG:        name, expr             // php 8.0 named parameters
 AST_NAMESPACE:        name, stmts
 AST_NEW:              class, args
 AST_NULLABLE_TYPE:    type                   // Used only since PHP 7.1

ast_data.c

@@ -94,6 +94,7 @@ const zend_ast_kind ast_kinds[] = {
 	ZEND_AST_ATTRIBUTE,
 	ZEND_AST_MATCH,
 	ZEND_AST_MATCH_ARM,
+	ZEND_AST_NAMED_ARG,
 	ZEND_AST_METHOD_CALL,
 	ZEND_AST_STATIC_CALL,
 	ZEND_AST_CONDITIONAL,
@@ -201,6 +202,7 @@ const char *ast_kind_to_name(zend_ast_kind kind) {
 		case ZEND_AST_ATTRIBUTE: return "AST_ATTRIBUTE";
 		case ZEND_AST_MATCH: return "AST_MATCH";
 		case ZEND_AST_MATCH_ARM: return "AST_MATCH_ARM";
+		case ZEND_AST_NAMED_ARG: return "AST_NAMED_ARG";
 		case ZEND_AST_METHOD_CALL: return "AST_METHOD_CALL";
 		case ZEND_AST_STATIC_CALL: return "AST_STATIC_CALL";
 		case ZEND_AST_CONDITIONAL: return "AST_CONDITIONAL";
@@ -631,6 +633,12 @@ zend_string *ast_kind_child_name(zend_ast_kind kind, uint32_t child) {
 				case 1: return AST_STR(str_expr);
 			}
 			return NULL;
+		case ZEND_AST_NAMED_ARG:
+			switch (child) {
+				case 0: return AST_STR(str_name);
+				case 1: return AST_STR(str_expr);
+			}
+			return NULL;
 		case ZEND_AST_METHOD_CALL:
 			switch (child) {
 				case 0: return AST_STR(str_expr);
@@ -790,6 +798,7 @@ void ast_register_kind_constants(INIT_FUNC_ARGS) {
 	REGISTER_NS_LONG_CONSTANT("ast", "AST_ATTRIBUTE", ZEND_AST_ATTRIBUTE, CONST_CS | CONST_PERSISTENT);
 	REGISTER_NS_LONG_CONSTANT("ast", "AST_MATCH", ZEND_AST_MATCH, CONST_CS | CONST_PERSISTENT);
 	REGISTER_NS_LONG_CONSTANT("ast", "AST_MATCH_ARM", ZEND_AST_MATCH_ARM, CONST_CS | CONST_PERSISTENT);
+	REGISTER_NS_LONG_CONSTANT("ast", "AST_NAMED_ARG", ZEND_AST_NAMED_ARG, CONST_CS | CONST_PERSISTENT);
 	REGISTER_NS_LONG_CONSTANT("ast", "AST_METHOD_CALL", ZEND_AST_METHOD_CALL, CONST_CS | CONST_PERSISTENT);
 	REGISTER_NS_LONG_CONSTANT("ast", "AST_STATIC_CALL", ZEND_AST_STATIC_CALL, CONST_CS | CONST_PERSISTENT);
 	REGISTER_NS_LONG_CONSTANT("ast", "AST_CONDITIONAL", ZEND_AST_CONDITIONAL, CONST_CS | CONST_PERSISTENT);

package.xml

@@ -33,6 +33,7 @@
   The values of `ast\flags\MODIFIER_*` and `ast\flags\PARAM_VARIADIC` had some overlap in some php 7 versions.
   The new constants will have the same values as `ast\flags\MODIFIER_*` in PHP 8.0+, but different values in PHP 7
   (and these flags will never be set in php 7).
+- Support PHP 8.0's named arguments.
  </notes>
  <contents>
   <dir name="/">
@@ -100,6 +101,7 @@
       <file name="php74_ordinary_class.phpt" role="test" />
       <file name="php74_parenthesized_conditional.phpt" role="test" />
       <file name="php74_type_hints.phpt" role="test" />
+      <file name="php80_named_params.phpt" role="test" />
       <file name="php80_noncapturing_catch.phpt" role="test" />
       <file name="php80_promotion.phpt" role="test" />
       <file name="php80_static_type.phpt" role="test" />

php_ast.h

@@ -66,6 +66,7 @@ extern ast_str_globals str_globals;
 # define ZEND_AST_ATTRIBUTE 0x2fd
 # define ZEND_AST_MATCH 0x2fc
 # define ZEND_AST_MATCH_ARM 0x2fb
+# define ZEND_AST_NAMED_ARG 0x2fa
 // NOTE: The first hex digit is the number of child nodes a given kind has
 #endif
 

scripts/generate_ast_data.php

@@ -132,6 +132,7 @@
     'ZEND_AST_ATTRIBUTE' => ['class', 'args'],
     'ZEND_AST_MATCH' => ['cond', 'stmts'],
     'ZEND_AST_MATCH_ARM' => ['cond', 'expr'],
+    'ZEND_AST_NAMED_ARG' => ['name', 'expr'],
 
     /* 3 child nodes */
     'ZEND_AST_METHOD_CALL' => ['expr', 'method', 'args'],

tests/attributes_01.phpt

@@ -11,13 +11,13 @@ $code = <<<'PHP'
 <?php
 namespace NS;
 
-<<SomeAttribute>>
-function test(<<namespace\SomeAttribute(2+2)>> Type $arg) {
+@@SomeAttribute
+function test(@@namespace\SomeAttribute(2+2) Type $arg) {
 }
 
-$x = <<SomeAttribute>> function () {};
+$x = @@SomeAttribute function () {};
 
-$y = <<SomeAttribute>> fn (<<\SomeAttribute>> $a) => $x;
+$y = @@SomeAttribute fn (@@\SomeAttribute $a) => $x;
 PHP;
 
 echo ast_dump(ast\parse_code($code, $version=70));

tests/attributes_02.phpt

@@ -11,16 +11,16 @@ $code = <<<'PHP'
 <?php
 namespace NS;
 
-<<\SomeAttribute()>>
+@@\SomeAttribute()
 class X {
-    <<Attr1>>
-    <<Attr2(true)>>
+    @@Attr1
+    @@Attr2(true)
     public $prop;
 
-    <<Attr3>>
+    @@Attr3
     public const CONST_WITH_ATTRIBUTE = 123;
 
-    <<Attr4>>
+    @@Attr4
     public static function hasAttribute() {}
 }
 PHP;

tests/metadata.phpt

@@ -119,6 +119,7 @@ AST_GROUP_USE: [USE_NORMAL, USE_FUNCTION, USE_CONST]
 AST_ATTRIBUTE: []
 AST_MATCH: []
 AST_MATCH_ARM: []
+AST_NAMED_ARG: []
 AST_METHOD_CALL: []
 AST_STATIC_CALL: []
 AST_CONDITIONAL: (combinable) [PARENTHESIZED_CONDITIONAL]

tests/php80_named_params.phpt

@@ -0,0 +1,52 @@
+--TEST--
+Named parameters in PHP 8.0
+--SKIPIF--
+<?php if (PHP_VERSION_ID < 80000) die('skip PHP >= 8.0 only'); ?>
+--FILE--
+<?php
+
+require __DIR__ . '/../util.php';
+
+$code = <<<'PHP'
+<?php
+$foo(first: 1, second: 2);
+count(var: $argv);
+$other->count(1, myVar:$foo, myVar: 1);  // error
+PHP;
+
+$node = ast\parse_code($code, $version=70);
+echo ast_dump($node), "\n";
+--EXPECTF--
+AST_STMT_LIST
+    0: AST_CALL
+        expr: AST_VAR
+            name: "foo"
+        args: AST_ARG_LIST
+            0: AST_NAMED_ARG
+                name: "first"
+                expr: 1
+            1: AST_NAMED_ARG
+                name: "second"
+                expr: 2
+    1: AST_CALL
+        expr: AST_NAME
+            flags: NAME_NOT_FQ (%d)
+            name: "count"
+        args: AST_ARG_LIST
+            0: AST_NAMED_ARG
+                name: "var"
+                expr: AST_VAR
+                    name: "argv"
+    2: AST_METHOD_CALL
+        expr: AST_VAR
+            name: "other"
+        method: "count"
+        args: AST_ARG_LIST
+            0: 1
+            1: AST_NAMED_ARG
+                name: "myVar"
+                expr: AST_VAR
+                    name: "foo"
+            2: AST_NAMED_ARG
+                name: "myVar"
+                expr: 1