Added tests

Author: tpunt

ast.c

@@ -210,7 +210,7 @@ static void ast_to_zval(zval *zv, zend_ast *ast, zend_long version) {
 		}
 	}
 
-	if (version >= 30) { // assumes 30 will be next version bump
+	if (version >= 30) {
 		switch (ast->kind) {
 			case ZEND_AST_SILENCE:
 				ast->kind = ZEND_AST_UNARY_OP;
@@ -300,7 +300,7 @@ static void ast_to_zval(zval *zv, zend_ast *ast, zend_long version) {
 }
 
 static int ast_check_version(zend_long version) {
-	if (version == 10 || version == 20 || version == 30) { // next version assumption
+	if (version == 10 || version == 20 || version == 30) {
 		return SUCCESS;
 	}
 

tests/unary_ops.phpt

@@ -0,0 +1,38 @@
+--TEST--
+Convert unary ops AST_(SILENCE|UNARY_(PLUS|MINUS)) to flags of ZEND_AST_UNARY_OP
+--FILE--
+<?php
+
+require __DIR__ . '/../util.php';
+
+$code = <<<'PHP'
+<?php
+@$a;
++1;
+-1;
+PHP;
+
+echo ast_dump(ast\parse_code($code, $version=20)), "\n";
+echo ast_dump(ast\parse_code($code, $version=30)), "\n";
+
+?>
+--EXPECT--
+AST_STMT_LIST
+    0: AST_SILENCE
+        0: AST_VAR
+            0: "a"
+    1: AST_UNARY_PLUS
+        0: 1
+    2: AST_UNARY_MINUS
+        0: 1
+AST_STMT_LIST
+    0: AST_UNARY_OP
+        flags: 258
+        0: AST_VAR
+            0: "a"
+    1: AST_UNARY_OP
+        flags: 259
+        0: 1
+    2: AST_UNARY_OP
+        flags: 260
+        0: 1