dom: Remove unnecessary objmap ptr null checks (#19092)

nielsdos · web-flow · commit 4aa8c2fe5dff · 2025-07-11T10:35:14.000+02:00
diff --git a/ext/dom/namednodemap.c b/ext/dom/namednodemap.c
@@ -35,10 +35,6 @@
 zend_long php_dom_get_namednodemap_length(dom_object *obj)
 {
 	dom_nnodemap_object *objmap = obj->ptr;
-	if (!objmap) {
-		return 0;
-	}
-
 	return objmap->handler->length(objmap);
 }
 
diff --git a/ext/dom/obj_map.c b/ext/dom/obj_map.c
@@ -294,9 +294,6 @@ static void dom_map_get_null_item(dom_nnodemap_object *map, zend_long index, zva
 zend_long php_dom_get_nodelist_length(dom_object *obj)
 {
 	dom_nnodemap_object *objmap = obj->ptr;
-	if (!objmap) {
-		return 0;
-	}
 
 	if (objmap->handler->use_cache) {
 		xmlNodePtr nodep = dom_object_get_node(objmap->baseobj);

Original file line number	Diff line number	Diff line change
`@@ -35,10 +35,6 @@`
`35`	`35`	`zend_long php_dom_get_namednodemap_length(dom_object *obj)`
`36`	`36`	`{`
`37`	`37`	`dom_nnodemap_object *objmap = obj->ptr;`
`38`		`- if (!objmap) {`
`39`		`- return 0;`
`40`		`- }`
`41`		`-`
`42`	`38`	`return objmap->handler->length(objmap);`
`43`	`39`	`}`
`44`	`40`
Original file line number	Diff line number	Diff line change
`@@ -294,9 +294,6 @@ static void dom_map_get_null_item(dom_nnodemap_object *map, zend_long index, zva`
`294`	`294`	`zend_long php_dom_get_nodelist_length(dom_object *obj)`
`295`	`295`	`{`
`296`	`296`	`dom_nnodemap_object *objmap = obj->ptr;`
`297`		`- if (!objmap) {`
`298`		`- return 0;`
`299`		`- }`
`300`	`297`
`301`	`298`	`if (objmap->handler->use_cache) {`
`302`	`299`	`xmlNodePtr nodep = dom_object_get_node(objmap->baseobj);`