Free opened_path when opened_path_len >= MAXPATHLEN

dixyes · nielsdos · commit 5dd965117a1d · 2025-07-27T10:54:21.000+02:00
Closes GH-19240.
diff --git a/NEWS b/NEWS
@@ -39,6 +39,9 @@ PHP                                                                        NEWS
     (ilutov)
   . Fix theoretical issues with hrtime() not being available. (nielsdos)
 
+- Windows:
+  . Free opened_path when opened_path_len >= MAXPATHLEN. (dixyes)
+
 31 Jul 2025, PHP 8.3.24
 
 - Calendar:
diff --git a/main/php_open_temporary_file.c b/main/php_open_temporary_file.c
@@ -157,6 +157,7 @@ static int php_do_open_temporary_file(const char *path, const char *pfx, zend_st
 			free(cwdw);
 			free(pfxw);
 			efree(new_state.cwd);
+			free(opened_path);
 			return -1;
 		}
 		assert(strlen(opened_path) == opened_path_len);

Original file line number	Diff line number	Diff line change
`@@ -157,6 +157,7 @@ static int php_do_open_temporary_file(const char path, const char pfx, zend_st`
`157`	`157`	`free(cwdw);`
`158`	`158`	`free(pfxw);`
`159`	`159`	`efree(new_state.cwd);`
	`160`	`+ free(opened_path);`
`160`	`161`	`return -1;`
`161`	`162`	`}`
`162`	`163`	`assert(strlen(opened_path) == opened_path_len);`