Skip to content

Commit e8f88e7

Browse files
committed
Fixes the real time benchmark
First of all, the last successful build had been before opcache was made required - therefore the PHP_OPCACHE setting should be 2 to manually enable it. Then, the manual flow should comment on the PR of the triggering repo (github.repository), not the repo of the benchmarked code (env.REPOSITORY).
1 parent 6f630a8 commit e8f88e7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/real-time-benchmark.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ jobs:
192192
PHP_BRANCH=${{ env.BRANCH }}
193193
PHP_COMMIT=$LAST_RESULT_SHA
194194
195-
PHP_OPCACHE=1
195+
PHP_OPCACHE=2
196196
PHP_JIT=0
197197
EOF
198198
- name: Setup PHP config - benchmarked PHP version
@@ -270,7 +270,7 @@ jobs:
270270
run: |
271271
cd ./php-version-benchmarks/tmp/php_${{ env.ID }}
272272
NEWEST_RESULT_DIRECTORY=$(ls -td ${{ github.workspace }}/php-version-benchmarks/docs/results/${{ env.YEAR }}/*/ | head -1)
273-
gh pr comment ${{ inputs.pull_request }} --body-file "${NEWEST_RESULT_DIRECTORY}result.md" --repo ${{ env.REPOSITORY }}
273+
gh pr comment ${{ inputs.pull_request }} --body-file "${NEWEST_RESULT_DIRECTORY}result.md" --repo ${{ github.repository }}
274274
- name: Cleanup
275275
if: always()
276276
run: |

0 commit comments

Comments
 (0)