Application::run method returns application return code

Author: phpjsdev623

parallel-lint

@@ -31,8 +31,8 @@ either expressed or implied, of the FreeBSD Project.
  */
 
 if (!defined('PHP_VERSION_ID') || PHP_VERSION_ID < 50400) {
-    echo "PHP Parallel Lint require PHP 5.4.0 or newer.", PHP_EOL;
-    die(254);
+    fwrite(STDERR, "PHP Parallel Lint require PHP 5.4.0 or newer." . PHP_EOL);
+    exit(254);
 }
 
 $autoloadLocations = [
@@ -60,4 +60,4 @@ if (!$loaded) {
 }
 
 $app = new JakubOnderka\PhpParallelLint\Application();
-$app->run();
+exit($app->run());

src/Application.php

@@ -13,49 +13,58 @@ class Application
 
     /**
      * Run the application
+     * @return int Return code
      */
     public function run()
     {
         if (in_array('proc_open', explode(',', ini_get('disable_functions')))) {
             echo "Function 'proc_open' is required, but it is disabled by disable_functions setting.", PHP_EOL;
-            die(self::FAILED);
+            return self::FAILED;
         }
+
         if (in_array('-h', $_SERVER['argv']) || in_array('--help', $_SERVER['argv'])) {
             $this->showUsage();
+            return self::SUCCESS;
         }
+
         if (in_array('-V', $_SERVER['argv']) || in_array('--version', $_SERVER['argv'])) {
             $this->showVersion();
-            die();
+            return self::SUCCESS;
         }
+
         try {
             $settings = Settings::parseArguments($_SERVER['argv']);
             if ($settings->stdin) {
                 $settings->addPaths(Settings::getPathsFromStdIn());
             }
             if (empty($settings->paths)) {
                 $this->showUsage();
+                return self::FAILED;
             }
             $manager = new Manager;
             $result = $manager->run($settings);
             if ($settings->ignoreFails) {
-                die($result->hasSyntaxError() ? self::WITH_ERRORS : self::SUCCESS);
+                return $result->hasSyntaxError() ? self::WITH_ERRORS : self::SUCCESS;
             } else {
-                die($result->hasError() ? self::WITH_ERRORS : self::SUCCESS);
+                return $result->hasError() ? self::WITH_ERRORS : self::SUCCESS;
             }
+
         } catch (InvalidArgumentException $e) {
             echo "Invalid option {$e->getArgument()}", PHP_EOL, PHP_EOL;
             $this->showOptions();
-            die(self::FAILED);
+            return self::FAILED;
+
         } catch (Exception $e) {
             if (isset($settings) && $settings->format === Settings::FORMAT_JSON) {
                 echo json_encode($e);
             } else {
                 echo $e->getMessage(), PHP_EOL;
             }
-            die(self::FAILED);
-        } catch (Exception $e) {
+            return self::FAILED;
+
+        } catch (\Exception $e) {
             echo $e->getMessage(), PHP_EOL;
-            die(self::FAILED);
+            return self::FAILED;
         }
     }
 
@@ -110,6 +119,5 @@ private function showUsage()
 
 USAGE;
         $this->showOptions();
-        die();
     }
 }

src/Manager.php

@@ -12,6 +12,7 @@ class Manager
     /**
      * @param null|Settings $settings
      * @return Result
+     * @throws Exception
      * @throws \Exception
      */
     public function run(Settings $settings = null)