Fixed handling of self, static, and parent

Author: lookyman

src/ServiceMap.php

@@ -75,7 +75,10 @@ public static function getServiceIdFromNode(Node $node)
 			return $node->value;
 		}
 		if ($node instanceof ClassConstFetch && $node->class instanceof Name) {
-			return $node->class->toString();
+			$serviceId = $node->class->toString();
+			if (!\in_array($serviceId, ['self', 'static', 'parent'], true)) {
+				return $serviceId;
+			}
 		}
 		return \null;
 	}

tests/Rules/ContainerInterfacePrivateServiceRuleTest.php

@@ -22,7 +22,7 @@ public function testGetPrivateService()
 		$this->analyse([__DIR__ . '/data/ExampleController.php'], [
 			[
 				'Service "private" is private.',
-				14,
+				15,
 			],
 		]);
 	}

tests/Rules/ContainerInterfaceUnknownServiceRuleTest.php

@@ -22,7 +22,11 @@ public function testGetUnknownService()
 		$this->analyse([__DIR__ . '/data/ExampleController.php'], [
 			[
 				'Service "service.not.found" is not registered in the container.',
-				20,
+				21,
+			],
+			[
+				'Service "Lookyman\PHPStan\Symfony\ServiceMap" is not registered in the container.',
+				27,
 			],
 		]);
 	}

tests/Rules/data/ExampleController.php

@@ -4,6 +4,7 @@
 
 namespace Lookyman\PHPStan\Symfony\Rules\data;
 
+use Lookyman\PHPStan\Symfony\ServiceMap;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 
 final class ExampleController extends Controller
@@ -21,16 +22,28 @@ public function getUnknownService()
 		$service->noMethod();
 	}
 
+	public function getUnknownServiceByClass()
+	{
+		$service = $this->get(ServiceMap::class);
+		$service->noMethod();
+	}
+
 	public function getVariableService(string $serviceKey)
 	{
 		$service = $this->get($serviceKey);
 		$service->noMethod();
 	}
 
-	public function getConcatenatedService(string $serviceKey)
+	public function getConcatenatedService()
 	{
 		$service = $this->get('service.' . self::class);
 		$service->noMethod();
 	}
 
+	public function getSelfService()
+	{
+		$service = $this->get(self::class);
+		$service->noMethod();
+	}
+
 }