distplot_updates

- hide validate functions from tab-tab helper
- add pandas example and pandas type to validation
- replace `**kwargs` with `rug_text` and `colors` in
- updated the docstring with Andrew’s nice terse suggestions
- hid tick label from rug plot
- modified rug_text so its indexed across datasets, not copied
- edited examples
  - added import numpy where needed
  - increased sample sizes
- reversed legend
- fix the show_legend issue so a legend is shown if the hist is hidden
- add test to test_core to check exception for `scipy_import = False`
- edit tests in test optional to reflect the changes (mentioned above)
made

Author: cldougl

plotly/tests/test_core/test_tools/test_figure_factory.py

@@ -802,3 +802,22 @@ def test_datetime_candlestick(self):
 
         self.assertEqual(candle, exp_candle)
 
+
+class TestDistplot(TestCase):
+
+    def test_scipy_import_error(self):
+
+        # make sure Import Error is raised when _scipy_imported = False
+
+        hist_data = [[1.1, 1.1, 2.5, 3.0, 3.5,
+                      3.5, 4.1, 4.4, 4.5, 4.5,
+                      5.0, 5.0, 5.2, 5.5, 5.5,
+                      5.5, 5.5, 5.5, 6.1, 7.0]]
+
+        group_labels = ['distplot example']
+
+        self.assertRaisesRegexp(ImportError,
+                                "FigureFactory.create_distplot requires scipy",
+                                tls.FigureFactory.create_distplot,
+                                hist_data, group_labels)
+

plotly/tests/test_optional/test_opt_tracefactory.py

@@ -49,16 +49,14 @@ def test_simple_distplot(self):
         dp = tls.FigureFactory.create_distplot(hist_data=[[1, 2, 2, 3]],
                                                group_labels=['distplot'])
         expected_dp_layout = {'barmode': 'overlay',
-                                         'hovermode': 'closest',
-                                         'xaxis1': {'anchor': 'y2',
-                                                    '___domain': [0.0, 1.0],
-                                                    'zeroline': False},
-                                         'yaxis1': {'anchor': 'free',
-                                                    '___domain': [0.35, 1],
-                                                    'position': 0.0},
-                                         'yaxis2': {'anchor': 'x1',
-                                                    '___domain': [0, 0.25],
-                                                    'dtick': 1}}
+                              'hovermode': 'closest',
+                              'legend': {'traceorder': 'reversed'},
+                              'xaxis1': {'anchor': 'y2', '___domain': [0.0, 1.0], 'zeroline': False},
+                              'yaxis1': {'anchor': 'free', '___domain': [0.35, 1], 'position': 0.0},
+                              'yaxis2': {'anchor': 'x1',
+                                         '___domain': [0, 0.25],
+                                         'dtick': 1,
+                                         'showticklabels': False}}
         self.assertEqual(dp['layout'], expected_dp_layout)
 
         expected_dp_data_hist = {'autobinx': False,
@@ -70,8 +68,7 @@ def test_simple_distplot(self):
                                  'type': 'histogram',
                                  'x': [1, 2, 2, 3],
                                  'xaxis': 'x1',
-                                 'xbins': {'end': 3.0, 'size': 1.0,
-                                           'start': 1.0},
+                                 'xbins': {'end': 3.0, 'size': 1.0, 'start': 1.0},
                                  'yaxis': 'y1'}
         self.assertEqual(dp['data'][0], expected_dp_data_hist)
 
@@ -85,8 +82,8 @@ def test_simple_distplot(self):
                                 'type': 'scatter',
                                 'x': [1, 2, 2, 3],
                                 'xaxis': 'x1',
-                                'y': ['distplot', 'distplot', 'distplot',
-                                      'distplot'],
+                                'y': ['distplot', 'distplot',
+                                      'distplot', 'distplot'],
                                 'yaxis': 'y2'}
         self.assertEqual(dp['data'][2], expected_dp_data_rug)
 
@@ -111,6 +108,7 @@ def test_distplot_more_args(self):
 
         expected_dp_layout = {'barmode': 'overlay',
                               'hovermode': 'closest',
+                              'legend': {'traceorder': 'reversed'},
                               'title': 'Dist Plot',
                               'xaxis1': {'anchor': 'y2', '___domain': [0.0, 1.0],
                                          'zeroline': False},