Skip to content

Commit 1227e2a

Browse files
archmojarchmoj
committed
revise download csv
1 parent 0b0642a commit 1227e2a

File tree

10 files changed

+34
-28
lines changed

10 files changed

+34
-28
lines changed

‎test/jasmine/performance_tests/assets/post_process.js

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,26 @@
1-
exports.writeRawDataAsCSV = function(traceName, allTests) {
2-
var str = 'number of traces,chart type,data points,run id,rendering time(ms)\n';
1+
exports.downloadCSV = function(traceName, allTests) {
2+
var str = [
3+
'number of traces',
4+
'chart type',
5+
'data points',
6+
'run id',
7+
'rendering time(ms)'
8+
].join(',') + '\n';
39
for(var k = 0; k < allTests.length; k++) {
410
var test = allTests[k];
511

612
for(var i = 0; i < test.raw.length; i++) {
7-
str +=
8-
(test.nTraces || 1) + ',' +
9-
(traceName + (test.mode ? '_' + test.mode : '')) + ',' +
10-
test.n + ',' + i + ',' +
11-
test.raw[i] + '\n';
13+
str += [
14+
(test.nTraces || 1),
15+
(traceName + (test.mode ? ' ' + test.mode : '')),
16+
test.n,
17+
i,
18+
test.raw[i]
19+
].join(',') + '\n';
1220
}
1321
}
1422

15-
console.log(str);
16-
17-
// download a CSV file
23+
// download file by browser
1824
var a = document.createElement('a');
1925
var myBlob = new Blob([str], {type: 'text/plain'})
2026
var url = window.URL.createObjectURL(myBlob);

‎test/jasmine/performance_tests/bar_test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var delay = require('../assets/delay');
33
var d3SelectAll = require('../../strict-d3').selectAll;
44
var Plotly = require('../../../lib/core');
55
var PlotlyBar = require('../../../lib/bar');
6-
var writeRawDataAsCSV = require('./assets/post_process').writeRawDataAsCSV;
6+
var downloadCSV = require('./assets/post_process').downloadCSV;
77
var nSamples = require('./assets/constants').nSamples;
88

99
Plotly.register(PlotlyBar);
@@ -157,7 +157,7 @@ tests.forEach(function(spec, index) {
157157
expect(nodes.size()).toEqual(spec.nTraces);
158158

159159
if(t === nTimes && index === tests.length - 1) {
160-
writeRawDataAsCSV('bar', tests);
160+
downloadCSV('bar', tests);
161161
}
162162
});
163163
});

‎test/jasmine/performance_tests/box_test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var delay = require('../assets/delay');
33
var d3SelectAll = require('../../strict-d3').selectAll;
44
var Plotly = require('../../../lib/core');
55
var PlotlyBox = require('../../../lib/box');
6-
var writeRawDataAsCSV = require('./assets/post_process').writeRawDataAsCSV;
6+
var downloadCSV = require('./assets/post_process').downloadCSV;
77
var nSamples = require('./assets/constants').nSamples;
88

99
Plotly.register(PlotlyBox);
@@ -157,7 +157,7 @@ tests.forEach(function(spec, index) {
157157
expect(nodes.size()).toEqual(spec.nTraces);
158158

159159
if(t === nTimes && index === tests.length - 1) {
160-
writeRawDataAsCSV('box', tests);
160+
downloadCSV('box', tests);
161161
}
162162
});
163163
});

‎test/jasmine/performance_tests/contour_test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var delay = require('../assets/delay');
33
var d3SelectAll = require('../../strict-d3').selectAll;
44
var Plotly = require('../../../lib/core');
55
var PlotlyContour = require('../../../lib/contour');
6-
var writeRawDataAsCSV = require('./assets/post_process').writeRawDataAsCSV;
6+
var downloadCSV = require('./assets/post_process').downloadCSV;
77
var nSamples = require('./assets/constants').nSamples;
88

99
Plotly.register(PlotlyContour);
@@ -90,7 +90,7 @@ tests.forEach(function(spec, index) {
9090
expect(nodes.size()).toEqual(1);
9191

9292
if(t === nTimes && index === tests.length - 1) {
93-
writeRawDataAsCSV('contour', tests);
93+
downloadCSV('contour', tests);
9494
}
9595
});
9696
});

‎test/jasmine/performance_tests/heatmap_test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var delay = require('../assets/delay');
33
var d3SelectAll = require('../../strict-d3').selectAll;
44
var Plotly = require('../../../lib/core');
55
var PlotlyHeatmap = require('../../../lib/heatmap');
6-
var writeRawDataAsCSV = require('./assets/post_process').writeRawDataAsCSV;
6+
var downloadCSV = require('./assets/post_process').downloadCSV;
77
var nSamples = require('./assets/constants').nSamples;
88

99
Plotly.register(PlotlyHeatmap);
@@ -90,7 +90,7 @@ tests.forEach(function(spec, index) {
9090
expect(nodes.size()).toEqual(1);
9191

9292
if(t === nTimes && index === tests.length - 1) {
93-
writeRawDataAsCSV('heatmap', tests);
93+
downloadCSV('heatmap', tests);
9494
}
9595
});
9696
});

‎test/jasmine/performance_tests/histogram_test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var delay = require('../assets/delay');
33
var d3SelectAll = require('../../strict-d3').selectAll;
44
var Plotly = require('../../../lib/core');
55
var PlotlyHistogram = require('../../../lib/histogram');
6-
var writeRawDataAsCSV = require('./assets/post_process').writeRawDataAsCSV;
6+
var downloadCSV = require('./assets/post_process').downloadCSV;
77
var nSamples = require('./assets/constants').nSamples;
88

99
Plotly.register(PlotlyHistogram);
@@ -157,7 +157,7 @@ tests.forEach(function(spec, index) {
157157
expect(nodes.size()).toEqual(spec.nTraces);
158158

159159
if(t === nTimes && index === tests.length - 1) {
160-
writeRawDataAsCSV('histogram', tests);
160+
downloadCSV('histogram', tests);
161161
}
162162
});
163163
});

‎test/jasmine/performance_tests/image_test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var delay = require('../assets/delay');
33
var d3SelectAll = require('../../strict-d3').selectAll;
44
var Plotly = require('../../../lib/core');
55
var PlotlyImage = require('../../../lib/image');
6-
var writeRawDataAsCSV = require('./assets/post_process').writeRawDataAsCSV;
6+
var downloadCSV = require('./assets/post_process').downloadCSV;
77
var nSamples = require('./assets/constants').nSamples;
88

99
Plotly.register(PlotlyImage);
@@ -100,7 +100,7 @@ tests.forEach(function(spec, index) {
100100
expect(nodes.size()).toEqual(1);
101101

102102
if(t === nTimes && index === tests.length - 1) {
103-
writeRawDataAsCSV('image', tests);
103+
downloadCSV('image', tests);
104104
}
105105
});
106106
});

‎test/jasmine/performance_tests/scatter_test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ var createGraphDiv = require('../assets/create_graph_div');
22
var delay = require('../assets/delay');
33
var d3SelectAll = require('../../strict-d3').selectAll;
44
var Plotly = require('../../../lib/core');
5-
var writeRawDataAsCSV = require('./assets/post_process').writeRawDataAsCSV;
5+
var downloadCSV = require('./assets/post_process').downloadCSV;
66
var nSamples = require('./assets/constants').nSamples;
77

88
var gd = createGraphDiv();
@@ -154,7 +154,7 @@ tests.forEach(function(spec, index) {
154154
expect(nodes.size()).toEqual(spec.nTraces);
155155

156156
if(t === nTimes && index === tests.length - 1) {
157-
writeRawDataAsCSV('scatter', tests);
157+
downloadCSV('scatter', tests);
158158
}
159159
});
160160
});

‎test/jasmine/performance_tests/scattergl_test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ var createGraphDiv = require('../assets/create_graph_div');
22
var delay = require('../assets/delay');
33
var Plotly = require('../../../lib/core');
44
var PlotlyScattergl = require('../../../lib/scattergl');
5-
var writeRawDataAsCSV = require('./assets/post_process').writeRawDataAsCSV;
5+
var downloadCSV = require('./assets/post_process').downloadCSV;
66
var nSamples = require('./assets/constants').nSamples;
77

88
Plotly.register(PlotlyScattergl);
@@ -153,7 +153,7 @@ tests.forEach(function(spec, index) {
153153
tests[index].raw[t] = delta;
154154

155155
if(t === nTimes && index === tests.length - 1) {
156-
writeRawDataAsCSV('scattergl', tests);
156+
downloadCSV('scattergl', tests);
157157
}
158158
});
159159
});

‎test/jasmine/performance_tests/violin_test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var delay = require('../assets/delay');
33
var d3SelectAll = require('../../strict-d3').selectAll;
44
var Plotly = require('../../../lib/core');
55
var PlotlyViolin = require('../../../lib/violin');
6-
var writeRawDataAsCSV = require('./assets/post_process').writeRawDataAsCSV;
6+
var downloadCSV = require('./assets/post_process').downloadCSV;
77
var nSamples = require('./assets/constants').nSamples;
88

99
Plotly.register(PlotlyViolin);
@@ -157,7 +157,7 @@ tests.forEach(function(spec, index) {
157157
expect(nodes.size()).toEqual(spec.nTraces);
158158

159159
if(t === nTimes && index === tests.length - 1) {
160-
writeRawDataAsCSV('violin', tests);
160+
downloadCSV('violin', tests);
161161
}
162162
});
163163
});

0 commit comments

Comments
 (0)