Skip to content

Commit e382d2f

Browse files
committed
clearer handling of showarrow attr when hoverlabel undefined
1 parent aac31fd commit e382d2f

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/components/fx/hover.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1922,14 +1922,16 @@ function alignHoverText(hoverLabels, rotateLabels, scaleX, scaleY) {
19221922
var offsetY = offsets.y;
19231923

19241924
var isMiddle = anchor === 'middle';
1925-
var showArrow = d.trace.hoverlabel?.showarrow;
1925+
// Get 'showarrow' attribute value from trace hoverlabel settings;
1926+
// if trace has no hoverlabel settings, we should show the arrow by default
1927+
var showArrow = 'hoverlabel' in d.trace ? d.trace.hoverlabel.showarrow : true;
19261928

19271929
var pathStr;
19281930
if(isMiddle) {
19291931
// middle aligned: rect centered on data
19301932
pathStr = 'M-' + pX(d.bx / 2 + d.tx2width / 2) + ',' + pY(offsetY - d.by / 2) +
19311933
'h' + pX(d.bx) + 'v' + pY(d.by) + 'h-' + pX(d.bx) + 'Z';
1932-
} else if(showArrow !== false) {
1934+
} else if(showArrow) {
19331935
// left or right aligned: side rect with arrow to data
19341936
pathStr = 'M0,0L' + pX(horzSign * HOVERARROWSIZE + offsetX) + ',' + pY(HOVERARROWSIZE + offsetY) +
19351937
'v' + pY(d.by / 2 - HOVERARROWSIZE) +

0 commit comments

Comments
 (0)