That pesky Python2 integer divide!

Author: nicholas-esterer

packages/python/plotly/plotly/subplots.py

@@ -640,7 +640,7 @@ def _checks(item, defaults):
     # Check to see that number of rows and columns does not conflict with
     # requested vertical_spacing and horizontal_spacing
     def _check_row_col_spacing(n, spacing):
-        if (n > 1) and (spacing > (1 / (n - 1))):
+        if (n > 1) and (spacing > (1.0 / (n - 1))):
             return False
         return True
 

packages/python/plotly/plotly/tests/test_core/test_subplots/test_make_subplots.py

@@ -116,15 +116,15 @@ def test_row_width_not_list_of_correct_numbers(self):
 
     def test_bad_row_spacing(self):
         with self.assertRaises(ValueError) as cm:
-            tls.make_subplots(rows=3, vertical_spacing=1 / 2 + 1e-6)
+            tls.make_subplots(rows=3, vertical_spacing=1.0 / 2.0 + 1e-6)
             assert (
                 cm.exception.args[0]
                 == "Vertical spacing must be less than or equal to 1 / (rows - 1)."
             )
 
     def test_bad_col_spacing(self):
         with self.assertRaises(ValueError) as cm:
-            tls.make_subplots(cols=3, horizontal_spacing=1 / 2 + 1e-6)
+            tls.make_subplots(cols=3, horizontal_spacing=1.0 / 2.0 + 1e-6)
             assert (
                 cm.exception.args[0]
                 == "Horizontal spacing must be less than or equal to 1 / (cols - 1)."