From 3eb01f336501ae20d1106430d657a732297337e8 Mon Sep 17 00:00:00 2001 From: Kunal Mandalia Date: Sat, 22 Jun 2019 18:13:22 +0100 Subject: [PATCH 1/2] fix: chrome extension error --- how-to-make-chrome-extensions/bear/content.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/how-to-make-chrome-extensions/bear/content.js b/how-to-make-chrome-extensions/bear/content.js index e11d1c4..b249bae 100644 --- a/how-to-make-chrome-extensions/bear/content.js +++ b/how-to-make-chrome-extensions/bear/content.js @@ -6,7 +6,8 @@ // }) const re = new RegExp('bear', 'gi') -const matches = document.documentElement.innerHTML.match(re) +const matches = document.documentElement.innerHTML.match(re) || [] + chrome.runtime.sendMessage({ url: window.location.href, count: matches.length From b47b31e3553cfe15dd9c9d53afd64fc77dd2b493 Mon Sep 17 00:00:00 2001 From: Chuck Benedict Date: Wed, 6 Nov 2019 08:56:15 -0800 Subject: [PATCH 2/2] Ignored signing on Mac. Enabled nodeIntegration (now disabled by default). --- electron-webpack-vuejs/.gitignore | 4 +++- electron-webpack-vuejs/package.json | 2 +- electron-webpack-vuejs/src/main/index.js | 5 ++++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/electron-webpack-vuejs/.gitignore b/electron-webpack-vuejs/.gitignore index 53c37a1..0841ed3 100644 --- a/electron-webpack-vuejs/.gitignore +++ b/electron-webpack-vuejs/.gitignore @@ -1 +1,3 @@ -dist \ No newline at end of file +dist +node_modules +package-lock.json \ No newline at end of file diff --git a/electron-webpack-vuejs/package.json b/electron-webpack-vuejs/package.json index 33d539f..cd652ea 100644 --- a/electron-webpack-vuejs/package.json +++ b/electron-webpack-vuejs/package.json @@ -5,7 +5,7 @@ "main": "index.js", "scripts": { "start": "electron-webpack dev", - "build": "electron-webpack && electron-builder" + "build": "electron-webpack && electron-builder -c.mac.identity=null" }, "author": "Kyle Robinson Young (http://dontkry.com)", "license": "MIT", diff --git a/electron-webpack-vuejs/src/main/index.js b/electron-webpack-vuejs/src/main/index.js index 374e69a..acd13a1 100644 --- a/electron-webpack-vuejs/src/main/index.js +++ b/electron-webpack-vuejs/src/main/index.js @@ -6,7 +6,10 @@ const isDevelopment = process.env.NODE_ENV !== 'production' app.on('ready', () => { let window = new BrowserWindow({ - width: 1024 + width: 1024, + webPreferences: { + nodeIntegration: true + } }) if (isDevelopment) { window.loadURL(`http://localhost:${process.env.ELECTRON_WEBPACK_WDS_PORT}`)