Updated tests

Author: Kully

plotly/tests/test_core/test_tools/test_figure_factory.py

@@ -1130,12 +1130,6 @@ class TestGantt(TestCase):
 
     def test_validate_gantt(self):
 
-        # checks if gantt is of valid form
-        df = [dict(Task="Job A")]
-
-        self.assertRaises(PlotlyError, tls.FigureFactory.create_gantt,
-                          df)
-
         df = [dict(Task='Job A',
                    Start='2009-02-01',
                    Finish='2009-08-30',

plotly/tools.py

@@ -1457,8 +1457,8 @@ def _validate_gantt(df):
         """
         Validates the inputted dataframe or list
         """
-        if isinstance(df, pd.core.frame.DataFrame):
-            # validate if df is a dataframe
+        if _pandas_imported and isinstance(df, pd.core.frame.DataFrame):
+            # validate that df has all the required keys
             for key in REQ_GANTT_KEYS:
                 if key not in df:
                     raise exceptions.PlotlyError("The columns in your data"
@@ -1479,19 +1479,14 @@ def _validate_gantt(df):
         if not isinstance(df, list):
             raise exceptions.PlotlyError("You must input either a dataframe "
                                          "or a list of dictionaries.")
+
         # validate if df is empty
         if len(df) <= 0:
             raise exceptions.PlotlyError("Your list is empty. It must contain "
                                          "at least one dictionary.")
         if not isinstance(df[0], dict):
             raise exceptions.PlotlyError("Your list must only "
                                          "include dictionaries.")
-        for key in REQ_GANTT_KEYS:
-            for dictionary in df:
-                if key not in dictionary:
-                    raise exceptions.PlotlyError("The columns in your data"
-                                                 "frame must be one "
-                                                 "of".format(REQ_GANTT_KEYS))
         return df
 
     @staticmethod