Skip to content

Commit e74519e

Browse files
committed
symcheck: Ignore symbols in .debug_gdb_scripts
Since [1], our object files may now contain a GDB script section. These symbols wind up with multiple instances in the archive but are weak, so we can safely ignore them in our duplicates check. This resolves the current CI failures. [1]: rust-lang/rust#143679
1 parent 9caec5d commit e74519e

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

crates/symbol-check/src/main.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,11 @@ fn verify_no_duplicates(archive: &Archive) {
215215
return;
216216
}
217217

218+
// GDB pretty printing symbols may show up more than once but are weak.
219+
if sym.section == ".debug_gdb_scripts" && sym.is_weak {
220+
return;
221+
}
222+
218223
// Windows has symbols for literal numeric constants, string literals, and MinGW pseudo-
219224
// relocations. These are allowed to have repeated definitions.
220225
let win_allowed_dup_pfx = ["__real@", "__xmm@", "??_C@_", ".refptr"];

0 commit comments

Comments
 (0)