Only run bootstrap tests in x test on CI

Kobzol · Kobzol · commit 3dac888c866a · 2025-07-25T22:32:48.000+02:00
diff --git a/src/bootstrap/src/core/build_steps/test.rs b/src/bootstrap/src/core/build_steps/test.rs
@@ -3132,7 +3132,11 @@ impl Step for Bootstrap {
     }
 
     fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
-        run.path("src/bootstrap")
+        // Bootstrap tests might not be perfectly self-contained and can depend on the external
+        // environment, submodules that are checked out, etc.
+        // Therefore we only run them by default on CI.
+        let runs_on_ci = run.builder.config.is_running_on_ci;
+        run.path("src/bootstrap").default_condition(runs_on_ci)
     }
 
     fn make_run(run: RunConfig<'_>) {

Original file line number	Diff line number	Diff line change
`@@ -3132,7 +3132,11 @@ impl Step for Bootstrap {`
`3132`	`3132`	`}`
`3133`	`3133`
`3134`	`3134`	`fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {`
`3135`		`- run.path("src/bootstrap")`
	`3135`	`+ // Bootstrap tests might not be perfectly self-contained and can depend on the external`
	`3136`	`+ // environment, submodules that are checked out, etc.`
	`3137`	`+ // Therefore we only run them by default on CI.`
	`3138`	`+ let runs_on_ci = run.builder.config.is_running_on_ci;`
	`3139`	`+ run.path("src/bootstrap").default_condition(runs_on_ci)`
`3136`	`3140`	`}`
`3137`	`3141`
`3138`	`3142`	`fn make_run(run: RunConfig<'_>) {`