Iterate on &fields.

Author: cjgillot

compiler/rustc_privacy/src/lib.rs

@@ -599,7 +599,7 @@ impl<'tcx> EmbargoVisitor<'tcx> {
             DefKind::Struct | DefKind::Union => {
                 // While structs and unions have type privacy, their fields do not.
                 let struct_def = self.tcx.adt_def(def_id);
-                for field in struct_def.non_enum_variant().fields.iter() {
+                for field in &struct_def.non_enum_variant().fields {
                     let def_id = field.did.expect_local();
                     let field_vis = self.tcx.local_visibility(def_id);
                     if field_vis.is_accessible_from(module, self.tcx) {
@@ -743,7 +743,7 @@ impl<'tcx> EmbargoVisitor<'tcx> {
                             self.update(ctor_def_id.expect_local(), variant_ev, Level::Reachable);
                         }
 
-                        for field in variant.fields.iter() {
+                        for field in &variant.fields {
                             let field = field.did.expect_local();
                             self.update(field, variant_ev, Level::Reachable);
                             self.reach(field, variant_ev).ty();
@@ -763,7 +763,7 @@ impl<'tcx> EmbargoVisitor<'tcx> {
                 let def = self.tcx.adt_def(owner_id).non_enum_variant();
                 if let Some(item_ev) = item_ev {
                     self.reach(owner_id.def_id, item_ev).generics().predicates();
-                    for field in def.fields.iter() {
+                    for field in &def.fields {
                         let field = field.did.expect_local();
                         self.update(field, item_ev, Level::Reachable);
                         if let Some(field_ev) = self.get(field) {
@@ -890,7 +890,7 @@ impl<'a, 'tcx> TestReachabilityVisitor<'a, 'tcx> {
                     if let Some(ctor_def_id) = variant.ctor_def_id() {
                         self.effective_visibility_diagnostic(ctor_def_id.expect_local());
                     }
-                    for field in variant.fields.iter() {
+                    for field in &variant.fields {
                         self.effective_visibility_diagnostic(field.did.expect_local());
                     }
                 }
@@ -900,7 +900,7 @@ impl<'a, 'tcx> TestReachabilityVisitor<'a, 'tcx> {
                 if let Some(ctor_def_id) = def.ctor_def_id() {
                     self.effective_visibility_diagnostic(ctor_def_id.expect_local());
                 }
-                for field in def.fields.iter() {
+                for field in &def.fields {
                     self.effective_visibility_diagnostic(field.did.expect_local());
                 }
             }