Skip to content

Commit 9854eb1

Browse files
committed
update flags for consistency
1 parent 889701d commit 9854eb1

File tree

1 file changed

+5
-4
lines changed
  • compiler/rustc_codegen_ssa/src/back

1 file changed

+5
-4
lines changed

compiler/rustc_codegen_ssa/src/back/link.rs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1011,11 +1011,12 @@ fn link_natively(
10111011
(Strip::Debuginfo, _) => {
10121012
strip_with_external_utility(sess, stripcmd, out_filename, &["--strip-debug"])
10131013
}
1014-
// Per the manpage, `-x` is the maximum safe strip level for dynamic libraries. (#93988)
1014+
1015+
// Per the manpage, --discard-all is the maximum safe strip level for dynamic libraries. (#93988)
10151016
(
10161017
Strip::Symbols,
10171018
CrateType::Dylib | CrateType::Cdylib | CrateType::ProcMacro | CrateType::Sdylib,
1018-
) => strip_with_external_utility(sess, stripcmd, out_filename, &["-x"]),
1019+
) => strip_with_external_utility(sess, stripcmd, out_filename, &["--discard-all"]),
10191020
(Strip::Symbols, _) => {
10201021
strip_with_external_utility(sess, stripcmd, out_filename, &["--strip-all"])
10211022
}
@@ -1032,8 +1033,8 @@ fn link_natively(
10321033
// `llvm-strip` and hope.
10331034
let stripcmd = if !sess.host.is_like_solaris { "rust-objcopy" } else { "/usr/bin/strip" };
10341035
match strip {
1035-
// Always preserve the symbol table (-x).
1036-
Strip::Debuginfo => strip_with_external_utility(sess, stripcmd, out_filename, &["-x"]),
1036+
// Do not strip the symbol table (-x).
1037+
Strip::Debuginfo => strip_with_external_utility(sess, stripcmd, out_filename, &["x"]),
10371038
// Strip::Symbols is handled via the --strip-all linker option.
10381039
Strip::Symbols => {}
10391040
Strip::None => {}

0 commit comments

Comments
 (0)