Supress swapping lhs and rhs in equality suggestion in extern macro

xizheyin · xizheyin · commit f65403df1dc2 · 2025-07-22T00:06:29.000+08:00
Signed-off-by: xizheyin &lt;xizheyin@smail.nju.edu.cn&gt;
diff --git a/compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs b/compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs
@@ -3533,6 +3533,12 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
                 .must_apply_modulo_regions()
         {
             let sm = self.tcx.sess.source_map();
+            // If the span of rhs_expr is in an external macro,
+            // we should not suggest to swap the equality. See issue #139050
+            if rhs_expr.span.in_external_macro(sm) {
+                return;
+            }
+
             if let Ok(rhs_snippet) = sm.span_to_snippet(rhs_expr.span)
                 && let Ok(lhs_snippet) = sm.span_to_snippet(lhs_expr.span)
             {

Original file line number	Diff line number	Diff line change
`@@ -3533,6 +3533,12 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {`
`3533`	`3533`	`.must_apply_modulo_regions()`
`3534`	`3534`	`{`
`3535`	`3535`	`let sm = self.tcx.sess.source_map();`
	`3536`	`+ // If the span of rhs_expr is in an external macro,`
	`3537`	`+ // we should not suggest to swap the equality. See issue #139050`
	`3538`	`+ if rhs_expr.span.in_external_macro(sm) {`
	`3539`	`+ return;`
	`3540`	`+ }`
	`3541`	`+`
`3536`	`3542`	`if let Ok(rhs_snippet) = sm.span_to_snippet(rhs_expr.span)`
`3537`	`3543`	`&& let Ok(lhs_snippet) = sm.span_to_snippet(lhs_expr.span)`
`3538`	`3544`	`{`