-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Open
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Description
Summary
For documention built by compiletest
directly, the build.disable-minification
setting is ignored.
Command used
./x test tests/rustdoc-js
Expected behaviour
If disable-minification
is set, this applies to all test suites, not just some of them.
Actual behaviour
The rustdoc-js
test suite always has minification enabled.
Bootstrap configuration (bootstrap.toml)
profile = "tools" # Includes one of the default files in src/bootstrap/defaults
change-id = 138986
rust.debuginfo-level = 1
rust.jemalloc = false
rust.download-rustc = false
rust.deny-warnings = false
build.docs-minification = false
Operating system
Arch Linux
HEAD
Additional context
This is an issue if an error occurs when running that test suite, as you won't get a meaningful line number.
The invocation site where --disable-minification
should be passed but isn't is at compiletest::runtest::document
.
Metadata
Metadata
Assignees
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.