Skip to content

Commit 4ba70a8

Browse files
jieyouxutraviscross
authored andcommitted
Address Affiliated work review feedback
1 parent c9f148d commit 4ba70a8

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

src/implementing_new_features.md

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -225,18 +225,23 @@ Which option to choose might depend on how significant the language change is, t
225225

226226
## Affiliated work
227227

228-
Once the feature is supported by rustc, there is other associated work that needs to be done to give users a complete experience:
228+
Once the feature is supported by rustc, there is other associated work that needs to be done to give users a complete experience. Think of it as the *language toolchain* developer experience, which doesn't only comprise of the language or compiler in isolation.
229229

230-
* Extending rustfmt to format any new syntax;
231-
* Extending rust-analyzer;
232-
* Documenting the feature in the Rust reference;
233-
* ...
230+
- Documenting the language feature in the [Rust Reference][reference].
231+
- (If applicable) Extending [`rustfmt`] to format any new syntax.
232+
- (If applicable) Extending [`rust-analyzer`]. This can depend on the nature of the language feature, as some features don't need to be blocked on *full* support.
233+
- A blocking concern is when a language feature degrades the user experience simply by existing before its support is implemented in [`rust-analyzer`].
234+
- Example blocking concern: new syntax that [`rust-analyzer`] can't parse -> bogus diagnostics, type inference changes -> bogus diagnostics.
234235

235236
## Stabilization
236237

237238
The final step in the feature lifecycle is [stabilization][stab], which is when the feature becomes available to all Rust users. At this point, backwards incompatible changes are no longer permitted (modulo soundness bugs and inference changes; see the lang team's [defined semver policies](https://rust-lang.github.io/rfcs/1122-language-semver.html) for full details). To learn more about stabilization, see the [stabilization guide][stab].
238239

240+
239241
[stab]: ./stabilization_guide.md
240242
[rust-blog]: https://github.com/rust-lang/blog.rust-lang.org/
241243
[twir]: https://github.com/rust-lang/this-week-in-rust
242244
[twir-cft]: https://this-week-in-rust.org/blog/2025/01/22/this-week-in-rust-583/#calls-for-testing
245+
[`rustfmt`]: https://github.com/rust-lang/rustfmt
246+
[`rust-analyzer`]: https://github.com/rust-lang/rust-analyzer
247+
[reference]: https://github.com/rust-lang/reference

0 commit comments

Comments
 (0)