Skip to content

Commit 8ed6b36

Browse files
nikomatsakislcnrRalfJungWaffleLapkin
authored andcommitted
Address review feedback
Co-authored-by: lcnr <[email protected]> Co-authored-by: Ralf Jung <[email protected]> Co-authored-by: waffle <[email protected]>
1 parent 7f7280e commit 8ed6b36

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/implementing_new_features.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ tests/ui/feature-gates/ --bless`.
209209

210210
## Call for testing
211211

212-
Once the implementation is complete, the feature will be available to nightly users, but not yet part of stable Rust. This is a good time to write a blog post on [one of the Rust blogs](https://github.com/rust-lang/blog.rust-lang.org/) and issue a call for testing (here are two example [blog](https://blog.rust-lang.org/inside-rust/2024/08/09/async-closures-call-for-testing.html) [posts](https://blog.rust-lang.org/2024/09/05/impl-trait-capture-rules.html) to give you the idea). The post should highlight how the feature works, what areas you'd like people to play with, and how they can supply feedback.
212+
Once the implementation is complete, the feature will be available to nightly users, but not yet part of stable Rust. This is a good time to write a blog post on [one of the Rust blogs](https://github.com/rust-lang/blog.rust-lang.org/) and issue a call for testing (here are three [example](https://blog.rust-lang.org/2021/08/03/GATs-stabilization-push.html) [blog](https://blog.rust-lang.org/inside-rust/2024/08/09/async-closures-call-for-testing.html) [posts](https://blog.rust-lang.org/2024/09/05/impl-trait-capture-rules.html) to give you the idea). The post should highlight how the feature works, what areas you'd like people to play with, and how they can supply feedback.
213213

214214
## Affiliated work
215215

src/stabilization_guide.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ The [template][srt] includes a series of questions that aim to surface interconn
5252
The stabilization report is typically posted as the main comment on the stabilization PR (see the next section).
5353
If you'd like to develop the stabilization report incrementally, we recommend adding it to
5454

55-
## Stabilization PR
55+
## Stabilization PR for a language feature
5656

5757
*This is for stabilizing language features. If you are stabilizing a library
5858
feature, see [the stabilization chapter of the std dev guide][std-guide-stabilization] instead.*

src/stabilization_report_template.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ An example for async closures: https://rustc-dev-guide.rust-lang.org/coroutine-c
2828

2929
### What outstanding bugs in the issue tracker involve this feature? Are they stabilization-blocking?
3030

31-
### Summarize contributors to the feature by name for recognition and assuredness that people involved in the feature agree with stabilization
32-
3331
### What FIXMEs are still in the code for that feature and why is it ok to leave them there?
3432

33+
### Summarize contributors to the feature by name for recognition and assuredness that people involved in the feature agree with stabilization
34+
3535
### Which tools need to be adjusted to support this feature. Has this work been done?
3636

3737
*Consider rustdoc, clippy, rust-analyzer, rustfmt, rustup, docs.rs.*
@@ -42,7 +42,7 @@ An example for async closures: https://rustc-dev-guide.rust-lang.org/coroutine-c
4242

4343
(Be sure to link to tests demonstrating that these tests are being done.)
4444

45-
### Can users use this feature to introduce undefined behavior? (Describe.)
45+
### Can users use this feature to introduce undefined behavior, or use this feature to break the abstraction of Rust and expose the underlying assembly-level implementation? (Describe.)
4646

4747
### What updates are needed to the reference/specification? (link to PRs when they exist)
4848

0 commit comments

Comments
 (0)