Skip to content

Commit f94ff17

Browse files
committed
Clean up number converter util return type.
1 parent 26fda64 commit f94ff17

File tree

19 files changed

+82
-37
lines changed

19 files changed

+82
-37
lines changed
Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1-
def try_int(text) -> int:
1+
from typing import Optional
2+
3+
4+
def try_int(text) -> Optional[int]:
25
try:
36
return int(text)
47
except:
5-
return 0
8+
return None
Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1-
def try_int(text) -> int:
1+
from typing import Optional
2+
3+
4+
def try_int(text) -> Optional[int]:
25
try:
36
return int(text)
47
except:
5-
return 0
8+
return None

app/ch12-forms/final/pypi_org/infrastructure/num_convert.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
def try_int(text) -> int:
1+
from typing import Optional
2+
3+
4+
def try_int(text) -> Optional[int]:
25
try:
36
return int(text)
47
except:
Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1-
def try_int(text) -> int:
1+
from typing import Optional
2+
3+
4+
def try_int(text) -> Optional[int]:
25
try:
36
return int(text)
47
except:
5-
return 0
8+
return None
Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1-
def try_int(text) -> int:
1+
from typing import Optional
2+
3+
4+
def try_int(text) -> Optional[int]:
25
try:
36
return int(text)
47
except:
5-
return 0
8+
return None

app/ch13-validation/starter/pypi_org/bin/load_data.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,11 +339,11 @@ def make_version_num(version_text):
339339
return major, minor, build
340340

341341

342-
def try_int(text) -> int:
342+
def try_int(text) -> Optional[int]:
343343
try:
344344
return int(text)
345345
except:
346-
return 0
346+
return None
347347

348348

349349
def init_db():
Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1-
def try_int(text) -> int:
1+
from typing import Optional
2+
3+
4+
def try_int(text) -> Optional[int]:
25
try:
36
return int(text)
47
except:
5-
return 0
8+
return None

app/ch14_testing/final/pypi_org/bin/load_data.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,11 +339,11 @@ def make_version_num(version_text):
339339
return major, minor, build
340340

341341

342-
def try_int(text) -> int:
342+
def try_int(text) -> Optional[int]:
343343
try:
344344
return int(text)
345345
except:
346-
return 0
346+
return None
347347

348348

349349
def init_db():
Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1-
def try_int(text) -> int:
1+
from typing import Optional
2+
3+
4+
def try_int(text) -> Optional[int]:
25
try:
36
return int(text)
47
except:
5-
return 0
8+
return None

app/ch14_testing/starter/pypi_org/bin/load_data.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,11 +339,11 @@ def make_version_num(version_text):
339339
return major, minor, build
340340

341341

342-
def try_int(text) -> int:
342+
def try_int(text) -> Optional[int]:
343343
try:
344344
return int(text)
345345
except:
346-
return 0
346+
return None
347347

348348

349349
def init_db():

0 commit comments

Comments
 (0)