Merge pull request #16 from sfdctaka/bumpKomaciVersion242.3.7

sfdctaka · web-flow · commit 098395121161 · 2023-03-20T11:29:02.000-07:00
Bump Komaci version. Update unit tests. Remove no-undefined-wire-config-property.
diff --git a/CODEOWNERS b/CODEOWNERS
@@ -1,3 +1,3 @@
 # Comment line immediately above ownership line is reserved for related other information. Please be careful while editing.
 #ECCN:Open Source
-* @khawkins @dbreese @pvandyk @sfdctaka @maliroteh-sf
+* @khawkins @dbreese @AndrewHuffman @sfdctaka @maliroteh-sf
diff --git a/lib/index.js b/lib/index.js
@@ -29,7 +29,6 @@ const noUnsupportedMemberVariableInMemberExpression = require('./rules/no-unsupp
 const noMultipleTemplateFiles = require('./rules/no-multiple-template-files');
 const noCompositionOnUnanalyzableGetterProperty = require('./rules/no-composition-on-unanalyzable-getter-property');
 const noCompositionOnUnanalyzablePropertyFromUnresolvableWire = require('./rules/no-composition-on-unanalyzable-property-from-unresolvable-wire');
-const noUndefinedWireConfigProperty = require('./rules/no-undefined-wire-config-property');
 const noCompositionOnUnanalyzablePropertyNonPublic = require('./rules/no-composition-on-unanalyzable-property-non-public');
 const noCompositionOnUnanalyzablePropertyMissing = require('./rules/no-composition-on-unanalyzable-property-missing');
 const noAssignmentExpressionForExternalComponents = require('./rules/no-assignment-expression-for-external-components');
@@ -105,7 +104,6 @@ module.exports = {
             noMemberExpressionReferenceToUnsupportedGlobal,
 
         // TODO: These rules do not have tests because Komaci itself did not have tests for them.
-        'no-undefined-wire-config-property': noUndefinedWireConfigProperty,
         'no-tagged-template-expression-contains-unsupported-namespace':
             noTaggedTemplateExpressionContainsUnsupportedNamespace,
         'no-render-function-contains-more-than-return-statement':
diff --git a/lib/rules/no-undefined-wire-config-property.js b/lib/rules/no-undefined-wire-config-property.js
diff --git a/lib/util/helper.js b/lib/util/helper.js
@@ -90,6 +90,12 @@ function getKomaciReport(ruleFilename, fileName, sourceFile) {
         }
     );
 
+    if (!diagnosticMessage) {
+        // No matching diagnostic message was found. Return an empty array to indicate that
+        // there is no lint warning/error to report back to the caller.
+        return [];
+    }
+
     eslintReports = eslintReports.filter((diagnostic) => {
         return diagnostic.code.value === diagnosticMessage[1].code;
     });
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@salesforce/eslint-plugin-lwc-graph-analyzer",
-    "version": "0.5.0",
+    "version": "0.6.0",
     "description": "ESLint plugin to analyze data graph in a LWC component",
     "contributors": [
         {
@@ -19,10 +19,6 @@
             "name": "Takashi Arai",
             "url": "https://github.com/sfdctaka"
         },
-        {
-            "name": "Peter Van Dyk",
-            "url": "https://github.com/pvandyk"
-        },
         {
             "name": "Dustin Breese",
             "url": "https://github.com/dbreese"
@@ -58,7 +54,7 @@
         "chai": "^4.3.7"
     },
     "dependencies": {
-        "@komaci/static-analyzer": "^242.3.2",
+        "@komaci/static-analyzer": "^242.3.7",
         "@lwc/metadata": "2.22.0-0",
         "@lwc/sfdc-compiler-utils": "2.22.0-0",
         "@lwc/errors": "2.22.0",
diff --git a/test/lib/rules/artifacts-combined-files/invalidGetterFunction/no-unsupported-member-variable-in-member-expression.js b/test/lib/rules/artifacts-combined-files/invalidGetterFunction/no-unsupported-member-variable-in-member-expression.js
@@ -14,8 +14,7 @@ describe('Bundle linting', function () {
     it('should return correct errors', function () {
         const messages = lintBundle(__filename, 'test.js');
         assert.equal(messages.length, 2);
-        const expected =
-            "Member expression contains reference to unsupported member variable 'blah'";
+        const expected = "This member expression references an unsupported member variable 'blah'.";
         assert.equal(messages[0].message, expected);
         assert.equal(messages[1].message, expected);
     });
diff --git a/test/lib/rules/artifacts-combined-files/multipleTemplateFiles/no-composition-on-unanalyzable-property-non-public.js b/test/lib/rules/artifacts-combined-files/multipleTemplateFiles/no-composition-on-unanalyzable-property-non-public.js
@@ -16,7 +16,7 @@ describe('Bundle linting', function () {
         assert.equal(messages.length, 1);
         assert.equal(
             messages[0].message,
-            "This child component references an unanalyzable property 'title' that is not a public property"
+            "This child component references an unanalyzable property 'title' that’s not a public property."
         );
     });
 });
diff --git a/test/lib/rules/artifacts-combined-files/multipleTemplateFiles/no-multiple-template-files.js b/test/lib/rules/artifacts-combined-files/multipleTemplateFiles/no-multiple-template-files.js
@@ -16,7 +16,7 @@ describe('Bundle linting', function () {
         assert.equal(messages.length, 1);
         assert.equal(
             messages[0].message,
-            'This analyzer does not support LWCs which render multiple template files'
+            'This analyzer doesn’t support components that render more than one template file.'
         );
     });
 });
diff --git a/test/lib/rules/artifacts-combined-files/unresolvedImageBinding/no-composition-on-unanalyzable-property-non-public.js b/test/lib/rules/artifacts-combined-files/unresolvedImageBinding/no-composition-on-unanalyzable-property-non-public.js
@@ -16,7 +16,7 @@ describe('Bundle linting', function () {
         assert.equal(messages.length, 1);
         assert.equal(
             messages[0].message,
-            "This image's src attribute is bound to an unanalyzable property 'propUnresolvable' that is not a public property"
+            "This image's src attribute is bound to an unanalyzable property 'propUnresolvable' that’s not a public property."
         );
     });
 });
diff --git a/test/lib/rules/artifacts-combined-files/unresolvedImageBindingEmptyClass/no-composition-on-unanalyzable-property-missing.js b/test/lib/rules/artifacts-combined-files/unresolvedImageBindingEmptyClass/no-composition-on-unanalyzable-property-missing.js
@@ -16,7 +16,7 @@ describe('Bundle linting', function () {
         assert.equal(messages.length, 1);
         assert.equal(
             messages[0].message,
-            "This image's src attribute is bound to a property 'testSrc' which does not exist in the corresponding script file"
+            "This image's src attribute is bound to a property 'testSrc' that doesn’t exist in the corresponding JavaScript file."
         );
     });
 });
diff --git a/test/lib/rules/artifacts-combined-files/unresolvedIterator/no-composition-on-unanalyzable-property-from-unresolvable-wire.js b/test/lib/rules/artifacts-combined-files/unresolvedIterator/no-composition-on-unanalyzable-property-from-unresolvable-wire.js
@@ -16,7 +16,7 @@ describe('Bundle linting', function () {
         assert.equal(messages.length, 1);
         assert.equal(
             messages[0].message,
-            "This iterator iterates upon an unanalyzable property 'contacts' that is wired by a unresolvable wire"
+            "This iterator iterates upon an unanalyzable property 'contacts' that is wired by an unresolvable wire."
         );
     });
 });
diff --git a/test/lib/rules/artifacts-combined-files/unresolvedIteratorGetter/no-composition-on-unanalyzable-getter-property.js b/test/lib/rules/artifacts-combined-files/unresolvedIteratorGetter/no-composition-on-unanalyzable-getter-property.js
@@ -16,7 +16,7 @@ describe('Bundle linting', function () {
         assert.equal(messages.length, 1);
         assert.equal(
             messages[0].message,
-            "This iterator iterates upon an unanalyzable getter property 'unresolvableGetter'"
+            "This iterator iterates upon an unanalyzable getter property 'unresolvableGetter'."
         );
     });
 });
diff --git a/test/lib/rules/no-assignment-expression-assigns-value-to-member-variable.js b/test/lib/rules/no-assignment-expression-assigns-value-to-member-variable.js
@@ -45,7 +45,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `Assignment expression cannot assign a value to member variable 'blah'`
+                        message: `This assignment expression can’t assign a value to the member variable 'blah'.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-assignment-expression-for-external-components.js b/test/lib/rules/no-assignment-expression-for-external-components.js
@@ -48,7 +48,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `Assignment Expressions are not supported for external components`
+                        message: `The assignment expression doesn’t support this component because the component is external to the Salesforce namespace.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-call-expression-references-unsupported-namespace.js b/test/lib/rules/no-call-expression-references-unsupported-namespace.js
@@ -52,7 +52,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `Call expression contains reference to an unsupported namespace 'testFunction'`
+                        message: `This call expression references an unsupported namespace: 'testFunction'.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-class-refers-to-parent-class-from-unsupported-namespace.js b/test/lib/rules/no-class-refers-to-parent-class-from-unsupported-namespace.js
@@ -27,7 +27,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `This class refers to a parent class from an unsupported namespace`
+                        message: `This class refers to a parent class from an unsupported namespace.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-eval-usage.js b/test/lib/rules/no-eval-usage.js
@@ -51,7 +51,7 @@ ruleTester.run('@salesforce/lwc-graph-analyzer/no-eval-usage', allRules.rules['n
             filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
             errors: [
                 {
-                    message: `Call expression contains non-portable identifier 'eval'`
+                    message: `This call expression contains a non-portable identifier: 'eval'.`
                 }
             ]
         }
diff --git a/test/lib/rules/no-expression-contains-module-level-variable-ref.js b/test/lib/rules/no-expression-contains-module-level-variable-ref.js
@@ -42,7 +42,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `Expression contains a reference to a variable at the module level: 'testModuleVar'`
+                        message: `This getter references a variable defined at the module level: 'testModuleVar'.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-functions-declared-within-getter-method.js b/test/lib/rules/no-functions-declared-within-getter-method.js
@@ -52,7 +52,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `Functions may not be declared within a getter method`
+                        message: `This function is defined within a getter or template expression. Functions defined within getters or template expressions are not supported.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-getter-contains-more-than-return-statement.js b/test/lib/rules/no-getter-contains-more-than-return-statement.js
@@ -48,7 +48,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `Supported getters can only contain a return statement`
+                        message: `Getters can only contain a return statement.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-member-expression-contains-non-portable-identifier.js b/test/lib/rules/no-member-expression-contains-non-portable-identifier.js
@@ -43,7 +43,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `Member expression contains non-portable identifier 'window'`
+                        message: `This member expression contains a non-portable identifier: 'window'.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-member-expression-reference-to-non-existent-member-variable.js b/test/lib/rules/no-member-expression-reference-to-non-existent-member-variable.js
@@ -48,7 +48,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `Member expression contains reference to non-existent member variable 'tempMemberVar'`
+                        message: `This member expression references a member variable that doesn’t exist: 'tempMemberVar'.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-member-expression-reference-to-super-class.js b/test/lib/rules/no-member-expression-reference-to-super-class.js
@@ -47,7 +47,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `Member expression contains reference to super class: 'SuperClassFunction'`
+                        message: `This member expression references the superclass 'SuperClassFunction'.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-member-expression-reference-to-unsupported-global.js b/test/lib/rules/no-member-expression-reference-to-unsupported-global.js
@@ -43,7 +43,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `Member expression contains reference to unsupported global: 'Object'`
+                        message: `This member expression contains a reference to the unsupported global variable 'Object'.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-member-expression-reference-to-unsupported-namespace-reference.js b/test/lib/rules/no-member-expression-reference-to-unsupported-namespace-reference.js
@@ -53,7 +53,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `Member expression contains reference to unsupported namespace reference: 'testObject'`
+                        message: `This member expression references an unsupported namespace: 'testObject'.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-missing-resource-cannot-prime-wire-adapter.js b/test/lib/rules/no-missing-resource-cannot-prime-wire-adapter.js
@@ -30,7 +30,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `The wire adapter cannot be primed because it refers to a missing resource`
+                        message: `This wire adapter can’t be primed because it refers to a missing resource.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-private-wire-config-property.js b/test/lib/rules/no-private-wire-config-property.js
@@ -32,10 +32,10 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `This wire configuration uses a property 'recordId1' that is private`
+                        message: `This wire configuration uses a property 'recordId1' that is private.`
                     },
                     {
-                        message: `This wire configuration uses a property 'recordId1' that is private`
+                        message: `This wire configuration uses a property 'recordId1' that is private.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-reference-to-class-functions.js b/test/lib/rules/no-reference-to-class-functions.js
@@ -55,7 +55,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `Call expression contains reference to function defined on the class 'testFunc2'`
+                        message: `This call expression references a function defined in the class 'testFunc2'. Functions defined in a class are not supported.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-reference-to-module-functions.js b/test/lib/rules/no-reference-to-module-functions.js
@@ -55,7 +55,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `Call expression contains reference to function defined on the module 'testFunc1'`
+                        message: `This call expression references a function defined in the module 'testFunc1'. Functions defined in a module are not supported.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-reference-to-unsupported-namespace-reference.js b/test/lib/rules/no-reference-to-unsupported-namespace-reference.js
@@ -43,7 +43,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `Reference to import 'bobo' from an unsupported namespace is not allowed`
+                        message: `This reference to import 'bobo' from an unsupported namespace isn’t allowed.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-unresolved-parent-class-reference.js b/test/lib/rules/no-unresolved-parent-class-reference.js
@@ -30,7 +30,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `This class refers to an unresolved parent class`
+                        message: `This class references a parent class that can’t be resolved.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-wire-adapter-of-resource-cannot-be-primed.js b/test/lib/rules/no-wire-adapter-of-resource-cannot-be-primed.js
@@ -60,7 +60,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `The wire adapter 'invalidWire' of resource 'lightning/uiAppsApi' cannot be primed`
+                        message: `The wire adapter 'invalidWire' of resource 'lightning/uiAppsApi' can’t be primed.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-wire-config-property-circular-wire-dependency.js b/test/lib/rules/no-wire-config-property-circular-wire-dependency.js
@@ -55,7 +55,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `The wire configuration input property 'wiredOutput3' of this wire is part of a chain of circular wire dependencies, and will result an infinite loop during runtime. Please refactor code to remove the circular dependency. Dependency chain: 'wiredOutput3->wiredOutput4->wiredOutput1->wiredOutput3'`
+                        message: `This input property is part of circular wire dependencies in this chain: 'wiredOutput3->wiredOutput4->wiredOutput1->wiredOutput3'.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-wire-config-property-uses-getter-function-returning-inaccessible-import.js b/test/lib/rules/no-wire-config-property-uses-getter-function-returning-inaccessible-import.js
@@ -43,7 +43,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `This wire configuration uses a property from a getter function named 'input' that returns an inaccessible import`
+                        message: `This wire configuration uses a property from a getter function named 'input' that returns an inaccessible import.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-wire-config-property-uses-getter-function-returning-non-literal.js b/test/lib/rules/no-wire-config-property-uses-getter-function-returning-non-literal.js
@@ -48,7 +48,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `This wire configuration uses a property from a getter function named 'config' that returns a non-literal`
+                        message: `This wire configuration uses a property from a getter function named 'config' that returns a non-literal value, which isn’t supported for static analysis.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-wire-config-property-uses-imported-artifact-from-unsupported-namespace.js b/test/lib/rules/no-wire-config-property-uses-imported-artifact-from-unsupported-namespace.js
@@ -33,7 +33,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `This wire configuration uses an imported artifact 'getBlah' from unsupported namespace 'nothing/uiObjectInfoApi'`
+                        message: `This wire configuration uses an imported artifact 'getBlah' from an unsupported namespace 'nothing/uiObjectInfoApi'.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-wire-config-references-non-local-property-reactive-value.js b/test/lib/rules/no-wire-config-references-non-local-property-reactive-value.js
@@ -40,7 +40,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `This wire configuration references a reactive value 'GetData' that is not a local property`
+                        message: `This wire configuration references a reactive value 'GetData' that’s not a local property.`
                     }
                 ]
             }
diff --git a/test/lib/rules/no-wire-configuration-property-using-output-of-non-primeable-wire.js b/test/lib/rules/no-wire-configuration-property-using-output-of-non-primeable-wire.js
diff --git a/yarn.lock b/yarn.lock
