Merge pull request #11 from khawkins/cleanup

Cleanup

Author: khawkins

.eslintrc

@@ -7,7 +7,10 @@
     "overrides": [
         {
             "files": ["lib/rules/*.{js,ts}"],
-            "extends": ["plugin:eslint-plugin/rules-recommended"]
+            "extends": ["plugin:eslint-plugin/rules-recommended"],
+            "rules": {
+                "eslint-plugin/prefer-message-ids": "off"  // Messages come straight from Komaci.
+            }
         }
     ],
     "env": {

.github/workflows/lint.yml

@@ -0,0 +1,18 @@
+name: lint
+run-name: Installs project and runs linting
+on: [ push, pull_request ]
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node: [ 16, 18 ]
+    name: Linting on Ubuntu with Node ${{ matrix.node }}
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node }}
+          cache: 'npm'
+      - run: yarn install
+      - run: yarn lint

.github/workflows/prettier.yml

@@ -0,0 +1,18 @@
+name: prettier
+run-name: Installs project and runs prettier checks
+on: [ push, pull_request ]
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node: [ 16, 18 ]
+    name: Prettier on Ubuntu with Node ${{ matrix.node }}
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node }}
+          cache: 'npm'
+      - run: yarn install
+      - run: yarn format

lib/configs/recommended.js

@@ -31,11 +31,14 @@ module.exports = {
         '@salesforce/lwc-graph-analyzer/no-wire-config-property-uses-imported-artifact-from-unsupported-namespace':
             'warn',
         '@salesforce/lwc-graph-analyzer/no-wire-adapter-of-resource-cannot-be-primed': 'warn',
-        '@salesforce/lwc-graph-analyzer/no-unsupported-member-variable-in-member-expression': 'warn',
+        '@salesforce/lwc-graph-analyzer/no-unsupported-member-variable-in-member-expression':
+            'warn',
         '@salesforce/lwc-graph-analyzer/no-multiple-template-files': 'warn',
-        '@salesforce/lwc-graph-analyzer/no-conditional-using-unanalyzable-non-public-property': 'warn',
+        '@salesforce/lwc-graph-analyzer/no-conditional-using-unanalyzable-non-public-property':
+            'warn',
         '@salesforce/lwc-graph-analyzer/no-conditional-on-unanalyzable-getter-property': 'warn',
-        '@salesforce/lwc-graph-analyzer/no-conditional-using-property-from-unresolvable-wire': 'warn',
+        '@salesforce/lwc-graph-analyzer/no-conditional-using-property-from-unresolvable-wire':
+            'warn',
         '@salesforce/lwc-graph-analyzer/no-image-reference-unanalyzable-source-property': 'warn',
         '@salesforce/lwc-graph-analyzer/no-image-reference-missing-source-property': 'warn',
         '@salesforce/lwc-graph-analyzer/no-iterate-on-unanalyzable-getter-property': 'warn',
@@ -51,7 +54,8 @@ module.exports = {
         '@salesforce/lwc-graph-analyzer/no-tagged-template-expression-contains-unsupported-namespace':
             'warn',
         '@salesforce/lwc-graph-analyzer/no-expression-contains-module-level-variable-ref': 'warn',
-        '@salesforce/lwc-graph-analyzer/no-call-expression-references-unsupported-namespace': 'warn',
+        '@salesforce/lwc-graph-analyzer/no-call-expression-references-unsupported-namespace':
+            'warn',
         '@salesforce/lwc-graph-analyzer/no-eval-usage': 'warn',
         '@salesforce/lwc-graph-analyzer/no-reference-to-class-functions': 'warn',
         '@salesforce/lwc-graph-analyzer/no-reference-to-module-functions': 'warn',
@@ -60,8 +64,10 @@ module.exports = {
             'warn',
         '@salesforce/lwc-graph-analyzer/no-member-expression-reference-to-unsupported-namespace-reference':
             'warn',
-        '@salesforce/lwc-graph-analyzer/no-member-expression-contains-non-portable-identifier': 'warn',
+        '@salesforce/lwc-graph-analyzer/no-member-expression-contains-non-portable-identifier':
+            'warn',
         '@salesforce/lwc-graph-analyzer/no-member-expression-reference-to-super-class': 'warn',
-        '@salesforce/lwc-graph-analyzer/no-member-expression-reference-to-unsupported-global': 'warn'
+        '@salesforce/lwc-graph-analyzer/no-member-expression-reference-to-unsupported-global':
+            'warn'
     }
-};
+};

package.json

@@ -66,7 +66,8 @@
         "@babel/core": "^7.20.2"
     },
     "scripts": {
-        "format": "prettier --write \"**/*.{js,json,md}\"",
+        "format": "prettier --list-different \"**/*.js\"",
+        "format:fix": "prettier --write \"**/*.{js,json}\"",
         "lint": "eslint lib test",
         "test": "yarn jest --coverage"
     },

test/lib/rules/artifacts-combined-files/unresolvableChildComponent/primingDiagnostic.json

@@ -7,9 +7,6 @@
 
 'use strict';
 
-//no-composition-on-unanalyzable-getter-property
-//no-assignment-expression-assigns-value-to-member-variable
-
 const { assert } = require('chai');
 const { lintBundle } = require('../helper');
 

test/lib/rules/artifacts-combined-files/unresolvedIteratorGetter/no-composition-on-unanalyzable-getter-property.js

@@ -52,7 +52,7 @@ ruleTester.run(
                 filename: 'lwc-code.js', // Komaci needs a fake filename to be provided from RuleTester or otherwise it fails to run
                 errors: [
                     {
-                        message: `Call expression contains reference to an unsupported namespace \'testFunction\'`
+                        message: `Call expression contains reference to an unsupported namespace 'testFunction'`
                     }
                 ]
             }