Skip to content

Commit e0df7fe

Browse files
committed
Simpler logic to always error except for sdist
Also added an environment variable for test purposes
1 parent 1225b17 commit e0df7fe

File tree

1 file changed

+15
-7
lines changed

1 file changed

+15
-7
lines changed

setup.py

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import os
2+
import sys
23
from datetime import datetime, MAXYEAR
34
from collections import namedtuple
45

@@ -85,18 +86,25 @@ def maybe_raise_error(checked_datetime):
8586
raise SystemExit(error_message)
8687

8788

88-
class AbortInstall(install):
89-
def run(self):
90-
now = datetime.now()
91-
maybe_raise_error(now)
89+
if __name__ == "__main__":
90+
# We allow python setup.py sdist to always work to be able to create the
91+
# sdist and upload it to PyPI
92+
sdist_mode = len(sys.argv) == 2 and sys.argv[1] == 'sdist'
9293

94+
if not sdist_mode:
95+
# environment variable for test purposes
96+
datetime_str = os.getenv('SKLEARN_DEPRECATED_SKLEARN_CHECKED_DATETIME', None)
97+
if datetime_str is None:
98+
checked_datetime = datetime.now()
99+
else:
100+
checked_datetime = datetime.fromisoformat(datetime_str)
101+
102+
maybe_raise_error(checked_datetime)
93103

94-
if __name__ == "__main__":
95104
setup(
96-
cmdclass={"install": AbortInstall},
97105
description="deprecated sklearn package, use scikit-learn instead",
98106
long_description=LONG_DESCRIPTION,
99107
long_description_content_type="text/markdown",
100108
name="sklearn",
101-
version="0.1.0a2",
109+
version="0.1.0a6",
102110
)

0 commit comments

Comments
 (0)