Restore backward compatibility and fix exception

Enable pathCoverage by default only when supported

Author: Maks3w

src/CodeCoverage.php

@@ -89,24 +89,18 @@ class PHP_CodeCoverage
     /**
      * @var bool
      */
-    private $pathCoverage = false;
+    private $pathCoverage;
 
     /**
      * Constructor.
      *
      * @param  PHP_CodeCoverage_Driver           $driver
      * @param  PHP_CodeCoverage_Filter           $filter
-     * @param  bool                              $pathCoverage
+     * @param  null|bool                         $pathCoverage `null` enables path coverage if supported.
      * @throws PHP_CodeCoverage_RuntimeException
      */
-    public function __construct(PHP_CodeCoverage_Driver $driver = null, PHP_CodeCoverage_Filter $filter = null, $pathCoverage = true)
+    public function __construct(PHP_CodeCoverage_Driver $driver = null, PHP_CodeCoverage_Filter $filter = null, $pathCoverage = null)
     {
-        if (!is_bool($pathCoverage)) {
-            throw PHP_CodeCoverage_Util_InvalidArgumentHelper::factory(
-                3,
-                'boolean'
-            );
-        }
 
         if ($driver === null) {
             $driver = $this->selectDriver($pathCoverage);
@@ -116,6 +110,15 @@ public function __construct(PHP_CodeCoverage_Driver $driver = null, PHP_CodeCove
             $filter = new PHP_CodeCoverage_Filter;
         }
 
+        if ($pathCoverage === null) {
+            $pathCoverage = version_compare(phpversion('xdebug'), '2.3.2', '>=');
+        } elseif (!is_bool($pathCoverage)) {
+            throw PHP_CodeCoverage_InvalidArgumentException::create(
+                3,
+                'boolean'
+            );
+        }
+
         $this->driver       = $driver;
         $this->filter       = $filter;
         $this->pathCoverage = $pathCoverage;

src/CodeCoverage/Driver/Xdebug.php

@@ -24,13 +24,10 @@ class PHP_CodeCoverage_Driver_Xdebug implements PHP_CodeCoverage_Driver
     /**
      * @param bool $pathCoverage
      */
-    public function __construct($pathCoverage = true)
+    public function __construct($pathCoverage = false)
     {
-        if (!extension_loaded('xdebug') ||
-            version_compare(phpversion('xdebug'), '2.3.2', '<')) {
-            throw new PHP_CodeCoverage_RuntimeException(
-                'This driver requires Xdebug 2.3.2 (or newer)'
-            );
+        if (!extension_loaded('xdebug')) {
+            throw new PHP_CodeCoverage_RuntimeException('This driver requires Xdebug');
         }
 
         if (!ini_get('xdebug.coverage_enable')) {
@@ -42,6 +39,12 @@ public function __construct($pathCoverage = true)
         $this->flags = XDEBUG_CC_UNUSED | XDEBUG_CC_DEAD_CODE;
 
         if ($pathCoverage) {
+            if (version_compare(phpversion('xdebug'), '2.3.2', '<')) {
+                throw new PHP_CodeCoverage_RuntimeException(
+                    'Path coverage requires Xdebug 2.3.2 (or newer)'
+                );
+            }
+
             $this->flags |= XDEBUG_CC_BRANCH_CHECK;
         }
     }