Skip to content

Commit 218f11e

Browse files
committed
Add coverage and complexity columns to class and method complexity tables.
1 parent c2a6cf5 commit 218f11e

File tree

2 files changed

+22
-10
lines changed

2 files changed

+22
-10
lines changed

src/Report/Html/Renderer/Dashboard.php

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -279,37 +279,45 @@ private function projectRisks(array $classes, string $baseLink): array
279279
$key = $className . '::' . $methodName;
280280
}
281281

282-
$methodRisks[$key] = $method['crap'];
282+
$methodRisks[$key] = $method;
283283
}
284284
}
285285

286286
if ($class['coverage'] < $this->thresholds->highLowerBound() &&
287287
$class['ccn'] > count($class['methods'])) {
288-
$classRisks[$className] = $class['crap'];
288+
$classRisks[$className] = $class;
289289
}
290290
}
291291

292-
arsort($classRisks);
293-
arsort($methodRisks);
292+
uasort($classRisks, function($a, $b) {
293+
return (intval($a['crap']) <=> intval($b['crap'])) * -1;
294+
});
295+
uasort($methodRisks, function($a, $b) {
296+
return (intval($a['crap']) <=> intval($b['crap'])) * -1;
297+
});
294298

295-
foreach ($classRisks as $className => $crap) {
299+
foreach ($classRisks as $className => $class) {
296300
$result['class'] .= sprintf(
297-
' <tr><td><a href="%s">%s</a></td><td class="text-right">%d</td></tr>' . "\n",
301+
' <tr><td><a href="%s">%s</a></td><td class="text-right">%d</td><td class="text-right">%.1f%%</td><td class="text-right">%d</td></tr>' . "\n",
298302
str_replace($baseLink, '', $classes[$className]['link']),
299303
$className,
300-
$crap,
304+
$class['ccn'],
305+
$class['coverage'],
306+
$class['crap']
301307
);
302308
}
303309

304-
foreach ($methodRisks as $methodName => $crap) {
310+
foreach ($methodRisks as $methodName => $methodVals) {
305311
[$class, $method] = explode('::', $methodName);
306312

307313
$result['method'] .= sprintf(
308-
' <tr><td><a href="%s"><abbr title="%s">%s</abbr></a></td><td class="text-right">%d</td></tr>' . "\n",
314+
' <tr><td><a href="%s"><abbr title="%s">%s</abbr></a></td><td class="text-right">%d</td><td class="text-right">%.1f%%</td><td class="text-right">%d</td></tr>' . "\n",
309315
str_replace($baseLink, '', $classes[$class]['methods'][$method]['link']),
310316
$methodName,
311317
$method,
312-
$crap,
318+
$methodVals['ccn'],
319+
$methodVals['coverage'],
320+
$methodVals['crap']
313321
);
314322
}
315323

src/Report/Html/Renderer/Template/dashboard.html.dist

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,8 @@
6767
<thead>
6868
<tr>
6969
<th>Class</th>
70+
<th class="text-right">Complexity</th>
71+
<th class="text-right">Coverage</th>
7072
<th class="text-right"><abbr title="Change Risk Anti-Patterns (CRAP) Index">CRAP</abbr></th>
7173
</tr>
7274
</thead>
@@ -120,6 +122,8 @@
120122
<thead>
121123
<tr>
122124
<th>Method</th>
125+
<th class="text-right">Complexity</th>
126+
<th class="text-right">Coverage</th>
123127
<th class="text-right"><abbr title="Change Risk Anti-Patterns (CRAP) Index">CRAP</abbr></th>
124128
</tr>
125129
</thead>

0 commit comments

Comments
 (0)