Skip to content

Commit 2ae3b1e

Browse files
Slamdunksebastianbergmann
authored andcommitted
Update test suite to reflect new executable LoC requirements
1 parent 5afa6e3 commit 2ae3b1e

File tree

50 files changed

+393
-451
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+393
-451
lines changed

tests/TestCase.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1346,28 +1346,24 @@ protected function getExpectedLineCoverageDataArrayForBankAccount(): array
13461346
0 => 'BankAccountTest::testBalanceIsInitiallyZero',
13471347
1 => 'BankAccountTest::testDepositWithdrawMoney',
13481348
],
1349-
9 => null,
13501349
13 => [],
13511350
14 => [],
13521351
15 => [],
13531352
16 => [],
1354-
18 => [],
13551353
22 => [
13561354
0 => 'BankAccountTest::testBalanceCannotBecomeNegative2',
13571355
1 => 'BankAccountTest::testDepositWithdrawMoney',
13581356
],
13591357
24 => [
13601358
0 => 'BankAccountTest::testDepositWithdrawMoney',
13611359
],
1362-
25 => null,
13631360
29 => [
13641361
0 => 'BankAccountTest::testBalanceCannotBecomeNegative',
13651362
1 => 'BankAccountTest::testDepositWithdrawMoney',
13661363
],
13671364
31 => [
13681365
0 => 'BankAccountTest::testDepositWithdrawMoney',
13691366
],
1370-
32 => null,
13711367
],
13721368
];
13731369
}
@@ -1380,28 +1376,24 @@ protected function getExpectedLineCoverageDataArrayForBankAccountInReverseOrder(
13801376
0 => 'BankAccountTest::testDepositWithdrawMoney',
13811377
1 => 'BankAccountTest::testBalanceIsInitiallyZero',
13821378
],
1383-
9 => null,
13841379
13 => [],
13851380
14 => [],
13861381
15 => [],
13871382
16 => [],
1388-
18 => [],
13891383
22 => [
13901384
0 => 'BankAccountTest::testBalanceCannotBecomeNegative2',
13911385
1 => 'BankAccountTest::testDepositWithdrawMoney',
13921386
],
13931387
24 => [
13941388
0 => 'BankAccountTest::testDepositWithdrawMoney',
13951389
],
1396-
25 => null,
13971390
29 => [
13981391
0 => 'BankAccountTest::testDepositWithdrawMoney',
13991392
1 => 'BankAccountTest::testBalanceCannotBecomeNegative',
14001393
],
14011394
31 => [
14021395
0 => 'BankAccountTest::testDepositWithdrawMoney',
14031396
],
1404-
32 => null,
14051397
],
14061398
];
14071399
}

tests/_files/BankAccount-clover-line.xml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<project timestamp="%i" name="BankAccount">
44
<file name="%s%eBankAccount.php">
55
<class name="BankAccount" namespace="global">
6-
<metrics complexity="5" methods="4" coveredmethods="3" conditionals="0" coveredconditionals="0" statements="10" coveredstatements="5" elements="14" coveredelements="8"/>
6+
<metrics complexity="5" methods="4" coveredmethods="3" conditionals="0" coveredconditionals="0" statements="9" coveredstatements="5" elements="13" coveredelements="8"/>
77
</class>
88
<line num="6" type="method" name="getBalance" visibility="public" complexity="1" crap="1" count="2"/>
99
<line num="8" type="stmt" count="2"/>
@@ -12,15 +12,14 @@
1212
<line num="14" type="stmt" count="0"/>
1313
<line num="15" type="stmt" count="0"/>
1414
<line num="16" type="stmt" count="0"/>
15-
<line num="18" type="stmt" count="0"/>
1615
<line num="20" type="method" name="depositMoney" visibility="public" complexity="1" crap="1" count="2"/>
1716
<line num="22" type="stmt" count="2"/>
1817
<line num="24" type="stmt" count="1"/>
1918
<line num="27" type="method" name="withdrawMoney" visibility="public" complexity="1" crap="1" count="2"/>
2019
<line num="29" type="stmt" count="2"/>
2120
<line num="31" type="stmt" count="1"/>
22-
<metrics loc="33" ncloc="33" classes="1" methods="4" coveredmethods="3" conditionals="0" coveredconditionals="0" statements="10" coveredstatements="5" elements="14" coveredelements="8"/>
21+
<metrics loc="33" ncloc="33" classes="1" methods="4" coveredmethods="3" conditionals="0" coveredconditionals="0" statements="9" coveredstatements="5" elements="13" coveredelements="8"/>
2322
</file>
24-
<metrics files="1" loc="33" ncloc="33" classes="1" methods="4" coveredmethods="3" conditionals="0" coveredconditionals="0" statements="10" coveredstatements="5" elements="14" coveredelements="8"/>
23+
<metrics files="1" loc="33" ncloc="33" classes="1" methods="4" coveredmethods="3" conditionals="0" coveredconditionals="0" statements="9" coveredstatements="5" elements="13" coveredelements="8"/>
2524
</project>
2625
</coverage>

tests/_files/BankAccount-clover-path.xml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<project timestamp="%i" name="BankAccount">
44
<file name="%s%eBankAccount.php">
55
<class name="BankAccount" namespace="global">
6-
<metrics complexity="5" methods="4" coveredmethods="3" conditionals="7" coveredconditionals="3" statements="10" coveredstatements="5" elements="21" coveredelements="11"/>
6+
<metrics complexity="5" methods="4" coveredmethods="3" conditionals="7" coveredconditionals="3" statements="9" coveredstatements="5" elements="20" coveredelements="11"/>
77
</class>
88
<line num="6" type="method" name="getBalance" visibility="public" complexity="1" crap="1" count="2"/>
99
<line num="8" type="stmt" count="2"/>
@@ -12,15 +12,14 @@
1212
<line num="14" type="stmt" count="0"/>
1313
<line num="15" type="stmt" count="0"/>
1414
<line num="16" type="stmt" count="0"/>
15-
<line num="18" type="stmt" count="0"/>
1615
<line num="20" type="method" name="depositMoney" visibility="public" complexity="1" crap="1" count="2"/>
1716
<line num="22" type="stmt" count="2"/>
1817
<line num="24" type="stmt" count="1"/>
1918
<line num="27" type="method" name="withdrawMoney" visibility="public" complexity="1" crap="1" count="2"/>
2019
<line num="29" type="stmt" count="2"/>
2120
<line num="31" type="stmt" count="1"/>
22-
<metrics loc="33" ncloc="33" classes="1" methods="4" coveredmethods="3" conditionals="7" coveredconditionals="3" statements="10" coveredstatements="5" elements="21" coveredelements="11"/>
21+
<metrics loc="33" ncloc="33" classes="1" methods="4" coveredmethods="3" conditionals="7" coveredconditionals="3" statements="9" coveredstatements="5" elements="20" coveredelements="11"/>
2322
</file>
24-
<metrics files="1" loc="33" ncloc="33" classes="1" methods="4" coveredmethods="3" conditionals="7" coveredconditionals="3" statements="10" coveredstatements="5" elements="21" coveredelements="11"/>
23+
<metrics files="1" loc="33" ncloc="33" classes="1" methods="4" coveredmethods="3" conditionals="7" coveredconditionals="3" statements="9" coveredstatements="5" elements="20" coveredelements="11"/>
2524
</project>
2625
</coverage>

tests/_files/BankAccount-cobertura-line.xml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!DOCTYPE coverage SYSTEM "http://cobertura.sourceforge.net/xml/coverage-04.dtd">
3-
<coverage line-rate="0.5" branch-rate="0" lines-covered="5" lines-valid="10" branches-covered="0" branches-valid="0" complexity="5" version="0.4" timestamp="%i">
3+
<coverage line-rate="0.55555555555556" branch-rate="0" lines-covered="5" lines-valid="9" branches-covered="0" branches-valid="0" complexity="5" version="0.4" timestamp="%i">
44
<sources>
55
<source>%s</source>
66
</sources>
77
<packages>
8-
<package name="BankAccount" line-rate="0.5" branch-rate="0" complexity="5">
8+
<package name="BankAccount" line-rate="0.55555555555556" branch-rate="0" complexity="5">
99
<classes>
10-
<class name="BankAccount" filename="BankAccount.php" line-rate="0.5" branch-rate="0" complexity="5">
10+
<class name="BankAccount" filename="BankAccount.php" line-rate="0.55555555555556" branch-rate="0" complexity="5">
1111
<methods>
1212
<method name="getBalance" signature="" line-rate="1" branch-rate="0" complexity="1">
1313
<lines>
@@ -20,7 +20,6 @@
2020
<line number="14" hits="0"/>
2121
<line number="15" hits="0"/>
2222
<line number="16" hits="0"/>
23-
<line number="18" hits="0"/>
2423
</lines>
2524
</method>
2625
<method name="depositMoney" signature="$balance" line-rate="1" branch-rate="0" complexity="1">
@@ -42,7 +41,6 @@
4241
<line number="14" hits="0"/>
4342
<line number="15" hits="0"/>
4443
<line number="16" hits="0"/>
45-
<line number="18" hits="0"/>
4644
<line number="22" hits="2"/>
4745
<line number="24" hits="1"/>
4846
<line number="29" hits="2"/>

tests/_files/BankAccount-cobertura-path.xml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!DOCTYPE coverage SYSTEM "http://cobertura.sourceforge.net/xml/coverage-04.dtd">
3-
<coverage line-rate="0.5" branch-rate="0.42857142857143" lines-covered="5" lines-valid="10" branches-covered="3" branches-valid="7" complexity="5" version="0.4" timestamp="%i">
3+
<coverage line-rate="0.55555555555556" branch-rate="0.42857142857143" lines-covered="5" lines-valid="9" branches-covered="3" branches-valid="7" complexity="5" version="0.4" timestamp="%i">
44
<sources>
55
<source>%s</source>
66
</sources>
77
<packages>
8-
<package name="BankAccount" line-rate="0.5" branch-rate="0.42857142857143" complexity="5">
8+
<package name="BankAccount" line-rate="0.55555555555556" branch-rate="0.42857142857143" complexity="5">
99
<classes>
10-
<class name="BankAccount" filename="BankAccount.php" line-rate="0.5" branch-rate="0.42857142857143" complexity="5">
10+
<class name="BankAccount" filename="BankAccount.php" line-rate="0.55555555555556" branch-rate="0.42857142857143" complexity="5">
1111
<methods>
1212
<method name="getBalance" signature="" line-rate="1" branch-rate="1" complexity="1">
1313
<lines>
@@ -20,7 +20,6 @@
2020
<line number="14" hits="0"/>
2121
<line number="15" hits="0"/>
2222
<line number="16" hits="0"/>
23-
<line number="18" hits="0"/>
2423
</lines>
2524
</method>
2625
<method name="depositMoney" signature="$balance" line-rate="1" branch-rate="1" complexity="1">
@@ -42,7 +41,6 @@
4241
<line number="14" hits="0"/>
4342
<line number="15" hits="0"/>
4443
<line number="16" hits="0"/>
45-
<line number="18" hits="0"/>
4644
<line number="22" hits="2"/>
4745
<line number="24" hits="1"/>
4846
<line number="29" hits="2"/>
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11

22

3-
Code Coverage Report:
3+
Code Coverage Report:
44
%s
5-
6-
Summary:
7-
Classes: 0.00% (0/1)
8-
Methods: 75.00% (3/4)
9-
Lines: 50.00% (5/10)
5+
6+
Summary:
7+
Classes: 0.00% (0/1)
8+
Methods: 75.00% (3/4)
9+
Lines: 55.56% (5/9)
1010

1111
BankAccount
12-
Methods: 75.00% ( 3/ 4) Lines: 50.00% ( 5/ 10)
12+
Methods: 75.00% ( 3/ 4) Lines: 55.56% ( 5/ 9)
Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11

22

3-
Code Coverage Report:
3+
Code Coverage Report:
44
%s
5-
6-
Summary:
7-
Classes: 0.00% (0/1)
8-
Methods: 75.00% (3/4)
9-
Paths: 60.00% (3/5)
5+
6+
Summary:
7+
Classes: 0.00% (0/1)
8+
Methods: 75.00% (3/4)
9+
Paths: 60.00% (3/5)
1010
Branches: 42.86% (3/7)
11-
Lines: 50.00% (5/10)
11+
Lines: 55.56% (5/9)
1212

1313
BankAccount
14-
Methods: 75.00% ( 3/ 4) Paths: 60.00% ( 3/ 5) Branches: 42.86% ( 3/ 7) Lines: 50.00% ( 5/ 10)
14+
Methods: 75.00% ( 3/ 4) Paths: 60.00% ( 3/ 5) Branches: 42.86% ( 3/ 7) Lines: 55.56% ( 5/ 9)

tests/_files/BankAccount-text-summary.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
Code Coverage Report Summary:
44
Classes: 0.00% (0/1)
55
Methods: 75.00% (3/4)
6-
Lines: 50.00% (5/10)
6+
Lines: 55.56% (5/9)
77

tests/_files/BankAccountWithUncovered-text-line.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Code Coverage Report:
66
Summary:
77
Classes: 0.00% (0/2)
88
Methods: 37.50% (3/8)
9-
Lines: 26.32% (5/19)
9+
Lines: 27.78% (5/18)
1010

1111
BankAccount
12-
Methods: 75.00% ( 3/ 4) Lines: 50.00% ( 5/ 10)
12+
Methods: 75.00% ( 3/ 4) Lines: 55.56% ( 5/ 9)
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11

22

3-
Code Coverage Report:
3+
Code Coverage Report:
44
%s
5-
6-
Summary:
7-
Classes: 0.00% (0/1)
8-
Methods: 75.00% (3/4)
9-
Lines: 50.00% (5/10)
5+
6+
Summary:
7+
Classes: 0.00% (0/1)
8+
Methods: 75.00% (3/4)
9+
Lines: 55.56% (5/9)
1010

1111
BankAccount
12-
Methods: 75.00% ( 3/ 4) Lines: 50.00% ( 5/ 10)
12+
Methods: 75.00% ( 3/ 4) Lines: 55.56% ( 5/ 9)

0 commit comments

Comments
 (0)