Skip to content

Commit 3b2714e

Browse files
Remove PHP_Token_Stream parameter from RawCodeCoverageData::fromUncoveredFile()
1 parent 2e58914 commit 3b2714e

File tree

3 files changed

+11
-23
lines changed

3 files changed

+11
-23
lines changed

src/CodeCoverage.php

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222
use function get_class;
2323
use function is_array;
2424
use function sort;
25-
use PHP_Token_Stream;
26-
use PHP_Token_Stream_CachingFactory;
2725
use PHPUnit\Framework\TestCase;
2826
use PHPUnit\Runner\PhptTestCase;
2927
use PHPUnit\Util\Test;
@@ -498,13 +496,7 @@ private function addUncoveredFilesFromFilter(): void
498496

499497
foreach ($uncoveredFiles as $uncoveredFile) {
500498
if (file_exists($uncoveredFile)) {
501-
if ($this->cacheTokens) {
502-
$tokens = PHP_Token_Stream_CachingFactory::get($uncoveredFile);
503-
} else {
504-
$tokens = new PHP_Token_Stream($uncoveredFile);
505-
}
506-
507-
$this->append(RawCodeCoverageData::fromUncoveredFile($uncoveredFile, $tokens), self::UNCOVERED_FILES);
499+
$this->append(RawCodeCoverageData::fromUncoveredFile($uncoveredFile), self::UNCOVERED_FILES);
508500
}
509501
}
510502
}

src/RawCodeCoverageData.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,9 @@ public static function fromXdebugWithMixedCoverage(array $rawCoverage): self
100100
return new self($lineCoverage, $functionCoverage);
101101
}
102102

103-
public static function fromUncoveredFile(string $filename, PHP_Token_Stream $tokens): self
103+
public static function fromUncoveredFile(string $filename): self
104104
{
105+
$tokens = new PHP_Token_Stream($filename);
105106
$lineCoverage = [];
106107

107108
$lines = file($filename);

tests/tests/RawCodeCoverageDataTest.php

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
namespace SebastianBergmann\CodeCoverage;
1111

1212
use function array_keys;
13-
use PHP_Token_Stream;
1413

1514
final class RawCodeCoverageDataTest extends TestCase
1615
{
@@ -264,8 +263,7 @@ public function testRemoveCoverageDataForLines(): void
264263

265264
public function testUseStatementsAreUncovered(): void
266265
{
267-
$file = TEST_FILES_PATH . 'source_with_use_statements.php';
268-
$tokens = new PHP_Token_Stream($file);
266+
$file = TEST_FILES_PATH . 'source_with_use_statements.php';
269267

270268
$this->assertEquals(
271269
[
@@ -280,28 +278,26 @@ public function testUseStatementsAreUncovered(): void
280278
21,
281279
22,
282280
],
283-
array_keys(RawCodeCoverageData::fromUncoveredFile($file, $tokens)->lineCoverage()[$file])
281+
array_keys(RawCodeCoverageData::fromUncoveredFile($file)->lineCoverage()[$file])
284282
);
285283
}
286284

287285
public function testEmptyClassesAreUncovered(): void
288286
{
289-
$file = TEST_FILES_PATH . 'source_with_empty_class.php';
290-
$tokens = new PHP_Token_Stream($file);
287+
$file = TEST_FILES_PATH . 'source_with_empty_class.php';
291288

292289
$this->assertEquals(
293290
[
294291
12,
295292
14,
296293
],
297-
array_keys(RawCodeCoverageData::fromUncoveredFile($file, $tokens)->lineCoverage()[$file])
294+
array_keys(RawCodeCoverageData::fromUncoveredFile($file)->lineCoverage()[$file])
298295
);
299296
}
300297

301298
public function testInterfacesAreUncovered(): void
302299
{
303-
$file = TEST_FILES_PATH . 'source_with_interface.php';
304-
$tokens = new PHP_Token_Stream($file);
300+
$file = TEST_FILES_PATH . 'source_with_interface.php';
305301

306302
$this->assertEquals(
307303
[
@@ -316,14 +312,13 @@ public function testInterfacesAreUncovered(): void
316312
16,
317313
17,
318314
],
319-
array_keys(RawCodeCoverageData::fromUncoveredFile($file, $tokens)->lineCoverage()[$file])
315+
array_keys(RawCodeCoverageData::fromUncoveredFile($file)->lineCoverage()[$file])
320316
);
321317
}
322318

323319
public function testInlineCommentsKeepTheLine(): void
324320
{
325-
$file = TEST_FILES_PATH . 'source_with_oneline_annotations.php';
326-
$tokens = new PHP_Token_Stream($file);
321+
$file = TEST_FILES_PATH . 'source_with_oneline_annotations.php';
327322

328323
$this->assertEquals(
329324
[
@@ -340,7 +335,7 @@ public function testInlineCommentsKeepTheLine(): void
340335
35,
341336
36,
342337
],
343-
array_keys(RawCodeCoverageData::fromUncoveredFile($file, $tokens)->lineCoverage()[$file])
338+
array_keys(RawCodeCoverageData::fromUncoveredFile($file)->lineCoverage()[$file])
344339
);
345340
}
346341

0 commit comments

Comments
 (0)