Revert "Fix Concat operations with variables #953"

This reverts commit d457c77.

Author: mvorisek

src/StaticAnalysis/ExecutableLinesFindingVisitor.php

@@ -166,14 +166,6 @@ private function getLines(NodeAbstract $node, bool $fromReturns): array
         }
 
         if ($node instanceof BinaryOp) {
-            if ($node instanceof BinaryOp\Concat &&
-                (
-                    $node->left instanceof Node\Expr\Variable ||
-                $node->right instanceof Node\Expr\Variable
-                )) {
-                return [$this->getNodeStartLine($node->right)];
-            }
-
             return $fromReturns ? $this->getLines($node->right, $fromReturns) : [];
         }
 

tests/_files/source_with_multiline_constant_return.php

@@ -492,29 +492,6 @@ public function unaryMinusNowdoc(): float
         ;
     }
 
-    public function concatWithVar(): string
-    {
-        $var1 = 'start';
-
-        $var1 =
-            <<<'EOF'
-right
-EOF
-            .
-            $var1
-        ;
-
-        $var1 =
-            $var1
-            .
-            <<<'EOF'
-left
-EOF
-        ;
-
-        return $var1;
-    }
-
     public
     function
     emptyMethod

tests/tests/Data/RawCodeCoverageDataTest.php

@@ -499,13 +499,6 @@ public function testReturnStatementWithConstantExprOnlyReturnTheLineOfLast(): vo
                 456,
                 466,
                 478,
-                490,
-                498,
-                500,
-                505,
-                508,
-                512, // This is correct: not the line with the $var1, but the right operand of the Concat
-                516,
                 527,
             ],
             array_keys(RawCodeCoverageData::fromUncoveredFile($file, new ParsingFileAnalyser(true, true))->lineCoverage()[$file])