Skip to content

Commit 8ff5e71

Browse files
committed
address acrolyix findings for readability
1 parent 5674217 commit 8ff5e71

File tree

4 files changed

+18
-21
lines changed

4 files changed

+18
-21
lines changed

docs/apis/webhooks/webhooks-reference-implementation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ Create a web job that on a weekly basis reads all the subscription IDs from the
157157
> [!NOTE]
158158
> This web job is not part of this reference implementation.
159159
160-
The actual renewal of a SharePoint list webhook can be done by using a [`PATCH /_api/web/lists('list-id')/subscriptions(‘subscriptionID’)`](./lists/update-subscription.md) REST call.
160+
The actual renewal of a SharePoint list webhook can be done by using a `[PATCH /_api/web/lists('list-id')/subscriptions(‘subscriptionID’)](./lists/update-subscription.md)` REST call.
161161

162162
In the reference implementation, updating of webhooks is implemented in the [WebHookManager](https://github.com/SharePoint/sp-dev-samples/blob/master/Samples/WebHooks.List/SharePoint.WebHooks.Common/WebHookManager.cs) class of the **SharePoint.WebHooks.Common** project.
163163

docs/declarative-customization/site-design-trigger-flow-tutorial.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ In order to capture the site creation event and create the corresponding list it
105105
Get-SPOSiteDesign
106106
```
107107

108-
To create a site design, you first need to create a site script. A site design is a container that refers to one or more site scripts.
108+
To create a site design, you first need to create a site script. A site design is a container that refers to one or more site scripts.
109109

110110
1. Copy the following JSON code to your clipboard and modify it. Set the **url** property to the value that you copied when you created the flow. The URL looks similar to the following:
111111

docs/declarative-customization/site-theming/sharepoint-site-theming-overview.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,9 @@ To do this, you must use a Windows PowerShell script with a CSOM (client-side ob
9191

9292
1. Verify that the following is returned:
9393

94-
`ClientSideThemingOptOut - 5138468e-3d76-4f72-9de4-e029f1245a7b`
94+
```powershell
95+
ClientSideThemingOptOut - 5138468e-3d76-4f72-9de4-e029f1245a7b
96+
```
9597
9698
For more information about Windows PowerShell, see [PowerShell](/powershell/scripting/overview).
9799

docs/spfx/release-1.16.md

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,9 @@ if (!!this.context.sdks.microsoftTeams) {
6565
}
6666
```
6767

68-
See more details around these options from following article
68+
For more information, see: [Extend Outlook and Office with the SharePoint Framework](office/overview.md).
6969

70-
* [Extend Outlook and Office with the SharePoint Framework](office/overview.md)
71-
72-
> [!Important]
70+
> [!IMPORTANT]
7371
> Using the Teams SDK v2 within the SharePoint Framework solutions is generally available starting from the 1.16 version, enabling usage of the Teams SDK v2 immediately.
7472
> Support for publishing Teams apps (including SPFx solutions) within the Outlook and in Office.com (Microsoft 365 app) is however still in preview and is planned to be generally available for both mobile and desktop experiences within the first half of calendar year 2023.
7573
@@ -81,7 +79,7 @@ This version supports the teams-js v2. `this.context.sdks.microsoftTeams.teamsJs
8179
> teams-js v2 is backward compatible with teams-js v1. We will continue to support v1 for existing solutions.
8280
8381
> [!TIP]
84-
> Teams JavaScript SDK v2 enables new scenarios for developers. See following announcement for additional details on the Teams JS SDK v2 capabilities - [Microsoft Teams JS SDK v2 is now generally available](https://devblogs.microsoft.com/microsoft365dev/microsoft-teams-js-sdk-v2-is-now-generally-available/)
82+
> Teams JavaScript SDK v2 enables new scenarios for developers. For more information on the Teams JS SDK v2 capabilities, see [Microsoft Teams JS SDK v2 is now generally available](https://devblogs.microsoft.com/microsoft365dev/microsoft-teams-js-sdk-v2-is-now-generally-available/).
8583
8684
### teams-js v2 typings support
8785

@@ -96,7 +94,7 @@ SPFx now supports React 17 by default (scaffolded as part of the solution).
9694

9795
### Ability to set dataVersion in web part's manifest
9896

99-
Set a data version for this preconfigured entry. This is optional and can be used in cases where the SPPKG is updated independently from code (e.g. hosted on a CDN). Web Parts can read this value for backwards compatibility with out of date default properties.
97+
Set a data version for this preconfigured entry. This is optional and can be used in cases where the SPPKG is updated independently from code (for example, hosted on a CDN). Web Parts can read this value for backwards compatibility with out of date default properties.
10098

10199
### General availability of Search Query extensions
102100

@@ -170,7 +168,7 @@ Node.js v12 & v14 are no longer supported. SPFx v1.16 requires Node.js v16.
170168
171169
## Preview Features and Capabilities
172170

173-
Following features are still in preview status as part of the 1.16 release and should not be used in production. We are looking into releasing them officially as part of the upcoming 1.17 release.
171+
Following features are still in preview status as part of the 1.16 release and shouldn't be used in production. We're looking into releasing them officially as part of the upcoming 1.17 release.
174172

175173
### Web part Top Actions
176174

@@ -202,10 +200,7 @@ export interface ITopActions {
202200
> Although type of Top Action Configuration is `IPropertyPaneField<any>` we currently support buttons and choice groups only.
203201
> It means you can use either `PropertyPaneChoiceGroup(...)` and `PropertyPaneButton(...)`, or specify your own configurations that will resolve to `IPropertyPaneField<IPropertyPaneChoiceGroupProps>` and `IPropertyPaneField<IPropertyPaneButtonProps>`
204202
205-
See more details on the code level guidance from the following article
206-
207-
* [Adding support for Top Actions](web-parts/guidance/getting-started-with-top-actions.md)
208-
203+
For more information on Top Actions, see [Adding support for Top Actions](web-parts/guidance/getting-started-with-top-actions.md).
209204

210205
## Deprecations
211206

@@ -219,18 +214,18 @@ Here's a list of specific issues fixed around SharePoint Framework since the pre
219214
### August-November Timeframe
220215

221216
- [#8146](https://github.com/SharePoint/sp-dev-docs/issues/8146) - SPFX Application Customizer breaks Anonymous Links for PDF Files
222-
- [#8266](https://github.com/SharePoint/sp-dev-docs/issues/8266) - SPFx 1.15 - Form Customiser does not work in View History
223-
- [#8272](https://github.com/SharePoint/sp-dev-docs/issues/8272) - SPFx 1.15 - Getting error when use form customier to view existing list item in Classic mode
217+
- [#8266](https://github.com/SharePoint/sp-dev-docs/issues/8266) - SPFx 1.15 - Form Customizer doesn't work in View History
218+
- [#8272](https://github.com/SharePoint/sp-dev-docs/issues/8272) - SPFx 1.15 - Getting error when use form customizer to view existing list item in Classic mode
224219
- [#8279](https://github.com/SharePoint/sp-dev-docs/issues/8279) - New icons in production environments
225-
- [#8301](https://github.com/SharePoint/sp-dev-docs/issues/8301) - Error When Revisiting Custom Teams ?app=portals App
220+
- [#8301](https://github.com/SharePoint/sp-dev-docs/issues/8301) - Error When Revisiting Custom Teams `?app=portals` App
226221
- [#8372](https://github.com/SharePoint/sp-dev-docs/issues/8372) - Applying permissions on Form Customizer
227222
- [#8379](https://github.com/SharePoint/sp-dev-docs/issues/8379) - SPFx `ListViewCommandSet` - `this.context.listView.selectedRows` is wrong in grouped lists
228223
- [#8467](https://github.com/SharePoint/sp-dev-docs/issues/8467) - Buttons (`onClick` events) in `BaseDialog` no longer working - ListView Command Set
229-
- [#8483](https://github.com/SharePoint/sp-dev-docs/issues/8483) - Multi-paged Webpart Property Panes - Pagination doesn't work as expected, stopping users from accessing pages
224+
- [#8483](https://github.com/SharePoint/sp-dev-docs/issues/8483) - Multi-paged web part property panes - Pagination doesn't work as expected, stopping users from accessing pages
230225
- [#8484](https://github.com/SharePoint/sp-dev-docs/issues/8484) - Web part property pane breaks when using React and office-ui-fabric-react in property pane field label
231-
- [#8482](https://github.com/SharePoint/sp-dev-docs/issues/8482) - React version mismatch causing SPFX list extensions to fail in O365
232-
- [#8487](https://github.com/SharePoint/sp-dev-docs/issues/8487) - SharePoint React 17 Upgrade causing "Invalid Hook call" error in SPFx Webpart
233-
- [#7324](https://github.com/SharePoint/sp-dev-docs/issues/7324) - SPFx license does not permit commercial use
226+
- [#8482](https://github.com/SharePoint/sp-dev-docs/issues/8482) - React version mismatch causing SPFx list extensions to fail in O365
227+
- [#8487](https://github.com/SharePoint/sp-dev-docs/issues/8487) - SharePoint React 17 Upgrade causing "Invalid Hook call" error in SPFx web part
228+
- [#7324](https://github.com/SharePoint/sp-dev-docs/issues/7324) - SPFx license doesn't permit commercial use
234229
- [#8331](https://github.com/SharePoint/sp-dev-docs/issues/8331) - Mechanism to version the preconfiguredEntries in the manifest
235230
- [#8510](https://github.com/SharePoint/sp-dev-docs/issues/8510) - SPFx sudden Minified React error #321
236231
- [#8496](https://github.com/SharePoint/sp-dev-docs/issues/8496) - React version mismatch causes property pane not displaying

0 commit comments

Comments
 (0)