Skip to content

Commit 240a42f

Browse files
committed
Use a single auth filter instead of a list
1 parent 471507c commit 240a42f

File tree

3 files changed

+7
-27
lines changed

3 files changed

+7
-27
lines changed

core/azure-core/src/main/java/com/microsoft/windowsazure/core/pipeline/apache/ApacheConfigSettings.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -100,13 +100,11 @@ public HttpClientBuilder applyConfig(HttpClientBuilder httpClientBuilder) {
100100
httpClientBuilder.addInterceptorFirst(new HttpHeaderRemovalFilter());
101101
}
102102

103-
if (properties.containsKey("AuthFilters"))
103+
if (properties.containsKey("AuthFilter"))
104104
{
105105
@SuppressWarnings("unchecked")
106-
ArrayList<ServiceRequestFilter> filters = (ArrayList<ServiceRequestFilter>) properties.get("AuthFilters");
107-
for (ServiceRequestFilter filter : filters) {
108-
httpClientBuilder.addInterceptorFirst(new FilterInterceptor(filter));
109-
}
106+
ServiceRequestFilter filter = (ServiceRequestFilter) properties.get("AuthFilter");
107+
httpClientBuilder.addInterceptorFirst(new FilterInterceptor(filter));
110108
}
111109

112110
return httpClientBuilder;

core/azure-core/src/main/java/com/microsoft/windowsazure/credentials/TokenCloudCredentials.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -116,16 +116,7 @@ public void setToken(String token) {
116116
@Override
117117
@SuppressWarnings("unchecked")
118118
public <T> void applyConfig(String profile, Map<String, Object> properties) {
119-
ArrayList<AdalAuthFilter> filters;
120-
if (!properties.containsKey("AuthFilters"))
121-
{
122-
filters = new ArrayList<AdalAuthFilter>();
123-
properties.put("AuthFilters", filters);
124-
} else {
125-
filters = (ArrayList<AdalAuthFilter>)properties.get("AuthFilters");
126-
}
127-
128-
filters.add(new AdalAuthFilter(this.token));
119+
properties.put("AuthFilter", new AdalAuthFilter(this.token));
129120
}
130121

131122
}

services/keyvault/azure-keyvault/src/main/java/com/microsoft/azure/keyvault/authentication/KeyVaultCredentials.java

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import com.microsoft.windowsazure.core.pipeline.filter.ServiceRequestContext;
3131
import com.microsoft.windowsazure.core.pipeline.filter.ServiceRequestFilter;
3232
import com.microsoft.windowsazure.credentials.CloudCredentials;
33+
import org.apache.http.auth.AUTH;
3334

3435
/**
3536
* An implementation of {@link CloudCredentials} that supports automatic bearer
@@ -38,7 +39,7 @@
3839
*/
3940
public abstract class KeyVaultCredentials extends CloudCredentials implements BearerCredentialsSupport {
4041

41-
private static final String AUTH_FILTERS_KEY = "AuthFilters";
42+
private static final String AUTH_FILTERS_KEY = "AuthFilter";
4243

4344
private final HashMap<String, Map<String, String>> cachedChallenges = new HashMap<String, Map<String, String>>();
4445

@@ -48,17 +49,7 @@ public <T> void applyConfig(String profile, Map<String, Object> properties) {
4849

4950
// Modifies properties to add our authenticating filter.
5051

51-
// First get the existing list of filters...
52-
ArrayList<ServiceRequestFilter> filters;
53-
if (!properties.containsKey(AUTH_FILTERS_KEY)) {
54-
filters = new ArrayList<ServiceRequestFilter>();
55-
properties.put(AUTH_FILTERS_KEY, filters);
56-
} else {
57-
filters = (ArrayList<ServiceRequestFilter>) properties.get(AUTH_FILTERS_KEY);
58-
}
59-
60-
// ...then we add our filter.
61-
filters.add(new ServiceRequestFilter() {
52+
properties.put(AUTH_FILTERS_KEY, new ServiceRequestFilter() {
6253

6354
@Override
6455
public void filter(ServiceRequestContext request) {

0 commit comments

Comments
 (0)