Skip to content

Commit 5fe2809

Browse files
committed
[PowerPC] Don't assert on SELECT_CC with i1 type
When we try to select a SELECT_CC on Power9, we check if it can be matched to a SETB instruction. In that function, we assert that the output type is i32/i64. This is unnecessary as it is perfectly reasonable to have an i1 SELECT_CC. Change that from an assert to an early exit condition. Fixes: https://bugs.llvm.org/show_bug.cgi?id=45448
1 parent e99169f commit 5fe2809

File tree

2 files changed

+92
-5
lines changed

2 files changed

+92
-5
lines changed

llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4249,13 +4249,10 @@ static bool mayUseP9Setb(SDNode *N, const ISD::CondCode &CC, SelectionDAG *DAG,
42494249
SDValue TrueRes = N->getOperand(2);
42504250
SDValue FalseRes = N->getOperand(3);
42514251
ConstantSDNode *TrueConst = dyn_cast<ConstantSDNode>(TrueRes);
4252-
if (!TrueConst)
4252+
if (!TrueConst || (N->getSimpleValueType(0) != MVT::i64 &&
4253+
N->getSimpleValueType(0) != MVT::i32))
42534254
return false;
42544255

4255-
assert((N->getSimpleValueType(0) == MVT::i64 ||
4256-
N->getSimpleValueType(0) == MVT::i32) &&
4257-
"Expecting either i64 or i32 here.");
4258-
42594256
// We are looking for any of:
42604257
// (select_cc lhs, rhs, 1, (sext (setcc [lr]hs, [lr]hs, cc2)), cc1)
42614258
// (select_cc lhs, rhs, -1, (zext (setcc [lr]hs, [lr]hs, cc2)), cc1)

llvm/test/CodeGen/PowerPC/pr45448.ll

Lines changed: 90 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,90 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
2+
; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \
3+
; RUN: -mcpu=pwr9 -ppc-asm-full-reg-names -ppc-vsr-nums-as-vr < %s | \
4+
; RUN: FileCheck %s
5+
define hidden void @julia_tryparse_internal_45896() #0 {
6+
; CHECK-LABEL: julia_tryparse_internal_45896:
7+
; CHECK: # %bb.0: # %top
8+
; CHECK-NEXT: ld r3, 0(r3)
9+
; CHECK-NEXT: cmpldi r3, 0
10+
; CHECK-NEXT: beq cr0, .LBB0_3
11+
; CHECK-NEXT: # %bb.1: # %top
12+
; CHECK-NEXT: cmpldi r3, 10
13+
; CHECK-NEXT: beq cr0, .LBB0_4
14+
; CHECK-NEXT: # %bb.2: # %top
15+
; CHECK-NEXT: .LBB0_3: # %fail194
16+
; CHECK-NEXT: .LBB0_4: # %L294
17+
; CHECK-NEXT: bc 12, 4*cr5+lt, .LBB0_6
18+
; CHECK-NEXT: # %bb.5: # %L294
19+
; CHECK-NEXT: bc 4, 4*cr5+lt, .LBB0_7
20+
; CHECK-NEXT: .LBB0_6: # %L1057.preheader
21+
; CHECK-NEXT: .LBB0_7: # %L670
22+
; CHECK-NEXT: lis r5, 4095
23+
; CHECK-NEXT: ori r5, r5, 65533
24+
; CHECK-NEXT: sldi r5, r5, 4
25+
; CHECK-NEXT: cmpdi r3, 0
26+
; CHECK-NEXT: sradi r4, r3, 63
27+
; CHECK-NEXT: mulhdu r3, r3, r5
28+
; CHECK-NEXT: maddld r6, r4, r5, r3
29+
; CHECK-NEXT: crnor 4*cr5+gt, eq, eq
30+
; CHECK-NEXT: cmpld r6, r3
31+
; CHECK-NEXT: mulld r3, r4, r5
32+
; CHECK-NEXT: cmpldi cr1, r3, 0
33+
; CHECK-NEXT: crandc 4*cr5+lt, lt, 4*cr1+eq
34+
; CHECK-NEXT: mulhdu. r3, r4, r5
35+
; CHECK-NEXT: bc 4, 4*cr5+gt, .LBB0_10
36+
; CHECK-NEXT: # %bb.8: # %L670
37+
; CHECK-NEXT: crorc 4*cr5+lt, 4*cr5+lt, eq
38+
; CHECK-NEXT: bc 4, 4*cr5+lt, .LBB0_10
39+
; CHECK-NEXT: # %bb.9: # %L917
40+
; CHECK-NEXT: .LBB0_10: # %L994
41+
top:
42+
%0 = load i64, i64* undef, align 8
43+
%1 = icmp ne i64 %0, 0
44+
%2 = sext i64 %0 to i128
45+
switch i64 %0, label %pass195 [
46+
i64 10, label %L294
47+
i64 16, label %L294.fold.split
48+
i64 0, label %fail194
49+
]
50+
51+
L294.fold.split: ; preds = %top
52+
unreachable
53+
54+
L294: ; preds = %top
55+
%3 = add nsw i32 0, -48
56+
%4 = zext i32 %3 to i128
57+
%5 = add i128 %4, 0
58+
switch i32 undef, label %L670 [
59+
i32 -1031471104, label %L1057.preheader
60+
i32 536870912, label %L1057.preheader
61+
]
62+
63+
L670: ; preds = %L294
64+
br label %L898
65+
66+
L1057.preheader: ; preds = %L294, %L294
67+
unreachable
68+
69+
L898: ; preds = %L670
70+
%umul = call { i128, i1 } @llvm.umul.with.overflow.i128(i128 %2, i128 %5)
71+
%umul.ov = extractvalue { i128, i1 } %umul, 1
72+
%value_phi102 = and i1 %1, %umul.ov
73+
%6 = or i1 %value_phi102, false
74+
br i1 %6, label %L917, label %L994
75+
76+
L917: ; preds = %L898
77+
unreachable
78+
79+
L994: ; preds = %L898
80+
unreachable
81+
82+
fail194: ; preds = %top
83+
unreachable
84+
85+
pass195: ; preds = %top
86+
unreachable
87+
}
88+
89+
; Function Attrs: nounwind readnone speculatable willreturn
90+
declare { i128, i1 } @llvm.umul.with.overflow.i128(i128, i128) #1

0 commit comments

Comments
 (0)