Revert "[clang-tidy] New check: bugprone-suspicious-include"

This reverts commit 1e0669b
(and follow-ups 698a127 and
52bbdad).
The tests fail fail on Windows, see https://reviews.llvm.org/D74669

Author: nico

clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

@@ -45,7 +45,6 @@
 #include "StringIntegerAssignmentCheck.h"
 #include "StringLiteralWithEmbeddedNulCheck.h"
 #include "SuspiciousEnumUsageCheck.h"
-#include "SuspiciousIncludeCheck.h"
 #include "SuspiciousMemsetUsageCheck.h"
 #include "SuspiciousMissingCommaCheck.h"
 #include "SuspiciousSemicolonCheck.h"
@@ -141,8 +140,6 @@ class BugproneModule : public ClangTidyModule {
         "bugprone-string-literal-with-embedded-nul");
     CheckFactories.registerCheck<SuspiciousEnumUsageCheck>(
         "bugprone-suspicious-enum-usage");
-    CheckFactories.registerCheck<SuspiciousIncludeCheck>(
-        "bugprone-suspicious-include");
     CheckFactories.registerCheck<SuspiciousMemsetUsageCheck>(
         "bugprone-suspicious-memset-usage");
     CheckFactories.registerCheck<SuspiciousMissingCommaCheck>(

clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt

@@ -37,7 +37,6 @@ add_clang_library(clangTidyBugproneModule
   StringIntegerAssignmentCheck.cpp
   StringLiteralWithEmbeddedNulCheck.cpp
   SuspiciousEnumUsageCheck.cpp
-  SuspiciousIncludeCheck.cpp
   SuspiciousMemsetUsageCheck.cpp
   SuspiciousMissingCommaCheck.cpp
   SuspiciousSemicolonCheck.cpp

clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.cpp

@@ -53,20 +53,13 @@ bool parseFileExtensions(StringRef AllFileExtensions,
   return true;
 }
 
-llvm::Optional<StringRef>
-getFileExtension(StringRef FileName, const FileExtensionsSet &FileExtensions) {
+bool isFileExtension(StringRef FileName,
+                     const FileExtensionsSet &FileExtensions) {
   StringRef Extension = llvm::sys::path::extension(FileName);
   if (Extension.empty())
-    return llvm::None;
+    return false;
   // Skip "." prefix.
-  if (!FileExtensions.count(Extension.substr(1)))
-    return llvm::None;
-  return Extension;
-}
-
-bool isFileExtension(StringRef FileName,
-                     const FileExtensionsSet &FileExtensions) {
-  return getFileExtension(FileName, FileExtensions).hasValue();
+  return FileExtensions.count(Extension.substr(1)) > 0;
 }
 
 } // namespace utils

clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.h

@@ -11,7 +11,6 @@
 
 #include "clang/Basic/SourceLocation.h"
 #include "clang/Basic/SourceManager.h"
-#include "llvm/ADT/Optional.h"
 #include "llvm/ADT/SmallSet.h"
 #include "llvm/ADT/StringRef.h"
 
@@ -37,12 +36,6 @@ bool isSpellingLocInHeaderFile(SourceLocation Loc, SourceManager &SM,
 /// extensions.
 inline StringRef defaultHeaderFileExtensions() { return ";h;hh;hpp;hxx"; }
 
-/// Returns recommended default value for the list of implementaiton file
-/// extensions.
-inline StringRef defaultImplementationFileExtensions() {
-  return "c;cc;cpp;cxx";
-}
-
 /// Returns recommended default value for the list of file extension
 /// delimiters.
 inline StringRef defaultFileExtensionDelimiters() { return ",;"; }
@@ -52,11 +45,6 @@ bool parseFileExtensions(StringRef AllFileExtensions,
                          FileExtensionsSet &FileExtensions,
                          StringRef Delimiters);
 
-/// Decides whether a file has a header file extension.
-/// Returns the file extension, if included in the provided set.
-llvm::Optional<StringRef>
-getFileExtension(StringRef FileName, const FileExtensionsSet &FileExtensions);
-
 /// Decides whether a file has one of the specified file extensions.
 bool isFileExtension(StringRef FileName,
                      const FileExtensionsSet &FileExtensions);

clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.cpp

@@ -82,13 +82,6 @@ New checks
 
   Checks for usages of identifiers reserved for use by the implementation.
 
-- New :doc:`bugprone-suspicious-include
-  <clang-tidy/checks/bugprone-suspicious-include>` check.
-
-  Finds cases where an include refers to what appears to be an implementation
-  file, which often leads to hard-to-track-down ODR violations, and diagnoses
-  them.
-
 - New :doc:`cert-oop57-cpp
   <clang-tidy/checks/cert-oop57-cpp>` check.