Skip to content

Commit 811b9fd

Browse files
committed
Merge 64582 from mainline
Fix PR3522. It's not safe to sink into landing pad BB's. llvm-svn: 64790
1 parent 11405df commit 811b9fd

File tree

2 files changed

+35
-0
lines changed

2 files changed

+35
-0
lines changed

llvm/lib/CodeGen/MachineSink.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,11 @@ bool MachineSinking::SinkInstruction(MachineInstr *MI, bool &SawStore) {
208208
// If there are no outputs, it must have side-effects.
209209
if (SuccToSinkTo == 0)
210210
return false;
211+
212+
// It's not safe to sink instructions to EH landing pad. Control flow into
213+
// landing pad is implicitly defined.
214+
if (SuccToSinkTo->isLandingPad())
215+
return false;
211216

212217
DEBUG(cerr << "Sink instr " << *MI);
213218
DEBUG(cerr << "to block " << *SuccToSinkTo);

llvm/test/CodeGen/X86/pr3522.ll

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
; RUN: llvm-as < %s | llc -march=x86 -stats |& not grep machine-sink
2+
; PR3522
3+
4+
target triple = "i386-pc-linux-gnu"
5+
@.str = external constant [13 x i8] ; <[13 x i8]*> [#uses=1]
6+
7+
define void @_ada_c34018a() {
8+
entry:
9+
%0 = tail call i32 @report__ident_int(i32 90) ; <i32> [#uses=1]
10+
%1 = trunc i32 %0 to i8 ; <i8> [#uses=1]
11+
invoke void @__gnat_rcheck_12(i8* getelementptr ([13 x i8]* @.str, i32 0, i32 0), i32 32) noreturn
12+
to label %invcont unwind label %lpad
13+
14+
invcont: ; preds = %entry
15+
unreachable
16+
17+
bb22: ; preds = %lpad
18+
ret void
19+
20+
return: ; preds = %lpad
21+
ret void
22+
23+
lpad: ; preds = %entry
24+
%2 = icmp eq i8 %1, 90 ; <i1> [#uses=1]
25+
br i1 %2, label %return, label %bb22
26+
}
27+
28+
declare void @__gnat_rcheck_12(i8*, i32) noreturn
29+
30+
declare i32 @report__ident_int(i32)

0 commit comments

Comments
 (0)