Skip to content

Commit b3696e4

Browse files
author
Devang Patel
committed
Do not strip llvm.used values.
llvm-svn: 46045
1 parent fb55354 commit b3696e4

File tree

3 files changed

+43
-3
lines changed

3 files changed

+43
-3
lines changed

llvm/lib/Transforms/IPO/StripSymbols.cpp

Lines changed: 25 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
#include "llvm/ValueSymbolTable.h"
3030
#include "llvm/TypeSymbolTable.h"
3131
#include "llvm/Support/Compiler.h"
32+
#include "llvm/ADT/SmallPtrSet.h"
3233
using namespace llvm;
3334

3435
namespace {
@@ -100,13 +101,34 @@ bool StripSymbols::runOnModule(Module &M) {
100101
// If we're not just stripping debug info, strip all symbols from the
101102
// functions and the names from any internal globals.
102103
if (!OnlyDebugInfo) {
104+
SmallPtrSet<const Constant *, 8> llvmUsedValues;
105+
Value *LLVMUsed = M.getValueSymbolTable().lookup("llvm.used");
106+
if (LLVMUsed) {
107+
// Collect values that are preserved as per explicit request.
108+
// llvm.used is used to list these values.
109+
if (GlobalVariable *GV = dyn_cast<GlobalVariable>(LLVMUsed)) {
110+
if (ConstantArray *InitList =
111+
dyn_cast<ConstantArray>(GV->getInitializer())) {
112+
for (unsigned i = 0, e = InitList->getNumOperands(); i != e; ++i) {
113+
if (ConstantExpr *CE =
114+
dyn_cast<ConstantExpr>(InitList->getOperand(i)))
115+
if (CE->isCast())
116+
llvmUsedValues.insert(CE->getOperand(0));
117+
}
118+
}
119+
}
120+
}
121+
103122
for (Module::global_iterator I = M.global_begin(), E = M.global_end();
104-
I != E; ++I)
105-
if (I->hasInternalLinkage())
123+
I != E; ++I) {
124+
if (I->hasInternalLinkage() && llvmUsedValues.count(I) == 0)
106125
I->setName(""); // Internal symbols can't participate in linkage
126+
else if (I->getName() == "llvm.used") {
127+
}
128+
}
107129

108130
for (Module::iterator I = M.begin(), E = M.end(); I != E; ++I) {
109-
if (I->hasInternalLinkage())
131+
if (I->hasInternalLinkage() && llvmUsedValues.count(I) == 0)
110132
I->setName(""); // Internal symbols can't participate in linkage
111133
StripSymtab(I->getValueSymbolTable());
112134
}
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
; RUN: llvm-as < %s | opt -strip | llvm-dis | grep foo | count 2
2+
; RUN: llvm-as < %s | opt -strip | llvm-dis | grep bar | count 2
3+
@llvm.used = appending global [2 x i8*] [ i8* bitcast (i32* @foo to i8*), i8* bitcast (i32 ()* @bar to i8*) ], section "llvm.metadata" ; <[2 x i8*]*> [#uses=0]
4+
@foo = internal constant i32 41 ; <i32*> [#uses=1]
5+
6+
define internal i32 @bar() nounwind {
7+
entry:
8+
ret i32 42
9+
}
10+
11+
define i32 @main() nounwind {
12+
entry:
13+
ret i32 0
14+
}
15+
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
load_lib llvm.exp
2+
3+
RunLLVMTests [lsort [glob -nocomplain $srcdir/$subdir/*.{ll,llx,c,cpp,tr}]]

0 commit comments

Comments
 (0)