Skip to content

Commit f722071

Browse files
committed
X86_MC::createX86MCSubtargetInfo - X86_MC::ParseX86Triple never returns an empty string. NFCI.
PVS Studio was complaining that the expression '!ArchFS.empty()' is always true.
1 parent 2cbb965 commit f722071

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -290,12 +290,9 @@ void X86_MC::initLLVMToSEHAndCVRegMapping(MCRegisterInfo *MRI) {
290290
MCSubtargetInfo *X86_MC::createX86MCSubtargetInfo(const Triple &TT,
291291
StringRef CPU, StringRef FS) {
292292
std::string ArchFS = X86_MC::ParseX86Triple(TT);
293-
if (!FS.empty()) {
294-
if (!ArchFS.empty())
295-
ArchFS = (Twine(ArchFS) + "," + FS).str();
296-
else
297-
ArchFS = FS;
298-
}
293+
assert(!ArchFS.empty() && "Failed to parse X86 triple");
294+
if (!FS.empty())
295+
ArchFS = (Twine(ArchFS) + "," + FS).str();
299296

300297
std::string CPUName = CPU;
301298
if (CPUName.empty())

0 commit comments

Comments
 (0)