Remove internal initializer method that takes a node as a parameter to prevent misuse that could break value semantics.

Author: newboadki

Singly Linked List/SinglyLinkedList.swift

@@ -83,24 +83,13 @@ public struct SinglyLinkedList<T>
 
     // MARK: INITIALIZERS
 
-    /// Creates a list with the given node.
-    /// NOTE: This method can break value semantics by accepting a node.
-    ///
-    /// - Parameter head: First node
-    internal init(head: SinglyLinkedListNode<T>)
-    {
-        self.storage = IndirectStorage()
-        self.append(node: head)
-    }
-    
-    
     /// Creates a list with a single element
     ///
     /// - Parameter value: element to populate the list with
     public init(value: T)
     {
-        let node = SinglyLinkedListNode<T>(value: value)
-        self.init(head: node)
+        self.init()
+        self.append(value: value)
     }
 
 

Singly Linked List/Tests/Tests/SinglyLinkedListTests.swift

@@ -47,7 +47,7 @@ class SinglyLinkedListTests: XCTestCase {
     }
 
     func testDelete() {
-        var list = SinglyLinkedList<Int>(head: SinglyLinkedListNode<Int>(value: 1))
+        var list: SinglyLinkedList<Int> = [1]
         list.append(value: 2)
         list.append(value: 3)
         list.append(value: 4)
@@ -87,7 +87,7 @@ class SinglyLinkedListTests: XCTestCase {
     }
 
     func testDeleteDuplicatesInPlace() {
-        var list = SinglyLinkedList<Int>(head: SinglyLinkedListNode<Int>(value: 1))
+        var list: SinglyLinkedList<Int> = [1]
         list.append(value: 2)
         list.append(value: 2)
         list.append(value: 3)