Skip to content

Commit 90682e8

Browse files
committed
few lint fixes.
1 parent fe1eba7 commit 90682e8

File tree

5 files changed

+20
-7
lines changed

5 files changed

+20
-7
lines changed

build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ buildscript {
88
annotation_version = '1.5.0'
99
material_version = '1.8.0'
1010
flexbox_version = '3.0.0'
11-
appcompat_version = '1.6.0'
11+
appcompat_version = '1.6.1'
1212
splash_version = '1.0.0'
1313
recyclerview_version = '1.2.1'
1414
preference_version = '1.2.0'
1515
cardview_version = '1.0.0'
16-
gson_version = '2.10.1'
1716
retrofit_version = '2.9.0'
17+
gson_version = '2.10.1'
1818
junit_version = '4.13.2'
1919
uiautomator_version = '2.2.0'
2020
espresso_version = '3.5.1'

lint.xml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,19 @@
99
<ignore regexp="com.google.android.material.appbar.AppBarLayout" />
1010
</issue>
1111

12+
<!-- Not required for Java projects -->
13+
<issue id="KotlinPropertyAccess" severity="ignore"/>
14+
<issue id="UnknownNullness" severity="ignore"/>
15+
16+
<issue id="InvalidPackage">
17+
<ignore regexp="kotlinx.coroutines.debug.AgentPremain"/>
18+
</issue>
19+
20+
<!-- don't notice about available alpha/beta versions -->
21+
<issue id="GradleDependency">
22+
<ignore regexp="is available: .*[alpha|beta|rc]" />
23+
</issue>
24+
1225
<issue id="UnusedIds">
1326
<ignore regexp="R.id.nav_graph"/>
1427
</issue>

mobile/src/main/java/io/syslogic/github/provider/QueryStringsMenuProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public void onCreateMenu(@NonNull Menu menu, @NonNull MenuInflater inflater) {
4242
@Override
4343
public boolean onMenuItemSelected(@NonNull MenuItem item) {
4444
if (getNavController() != null) {
45-
if (item.getItemId() == R.id.menu_action_bookmark_add) {
45+
if (item.getItemId() == R.id.menu_action_query_string_add) {
4646
getNavController().navigate(R.id.action_queryStringsFragment_to_queryStringFragment);
4747
return true;
4848
}

mobile/src/main/res/menu/query_strings.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
tools:context=".activity.NavHostActivity">
77

88
<item
9-
android:id="@+id/menu_action_bookmark_add"
9+
android:id="@+id/menu_action_query_string_add"
1010
android:icon="@drawable/ic_baseline_bookmark_add_48"
11-
android:title="@string/menu_action_bookmark_add"
11+
android:title="@string/menu_action_query_string_add"
1212
android:orderInCategory="100"
1313
app:showAsAction="always"/>
1414

mobile/src/main/res/values/strings.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
<string name="summary_preference_debug_logging">Enable verbose logging</string>
2020

2121
<string name="menu_action_preferences">Preferences</string>
22-
<string name="menu_action_query_strings">Bookmarks</string>
23-
<string name="menu_action_bookmark_add">Add Bookmark</string>
22+
<string name="menu_action_query_strings">Query Strings</string>
23+
<string name="menu_action_query_string_add">Add Query Strings</string>
2424

2525
<string name="text_bookmarks">Bookmarks</string>
2626
<string name="text_edit_bookmark">Edit Bookmark</string>

0 commit comments

Comments
 (0)