access scope changed.

syslogic · syslogic · commit de9918b60fa5 · 2023-08-27T15:22:03.000+02:00
diff --git a/mobile/lint.xml b/mobile/lint.xml
@@ -23,33 +23,38 @@
     </issue>
 
     <issue id="SyntheticAccessor">
-        <ignore regexp="LOG_TAG" />
+
     </issue>
 
     <issue id="UnusedResources">
-        <ignore regexp="R.layout.*" />
-        <ignore regexp="R.string.tools_*" />
-        <ignore regexp="R.string.text_pager_*" />
-        <ignore regexp="R.string.text_stargazers" />
-        <ignore regexp="R.string.text_subscribers" />
-        <ignore regexp="R.string.text_networks" />
-        <ignore regexp="R.drawable.baseline_cloud_download_*" />
+        <ignore regexp="R.layout.*"/>
+        <ignore regexp="R.string.tools_*"/>
+        <ignore regexp="R.string.text_pager_*"/>
+        <ignore regexp="R.string.text_stargazers"/>
+        <ignore regexp="R.string.text_subscribers"/>
+        <ignore regexp="R.string.text_networks"/>
+        <ignore regexp="R.string.summary_personal_access_token"/>
+        <ignore regexp="R.string.summary_personal_access_token_alt"/>
+        <ignore regexp="R.drawable.baseline_cloud_download_*"/>
+        <ignore regexp="R.mipmap.ic_launcher"/>
+        <ignore regexp="R.mipmap.ic_launcher_round"/>
+        <ignore regexp="R.mipmap.ocotocat"/>
     </issue>
 
     <!-- NotifyDataSetChanged is fine when clearing the adapter. -->
     <issue id="NotifyDataSetChanged">
-        <ignore regexp="io.syslogic.github.recyclerview.RepositorySearchLinearView" />
+        <ignore regexp="io.syslogic.github.recyclerview.RepositorySearchLinearView"/>
     </issue>
 
     <issue id="UnknownNullness">
-        <ignore regexp="io.syslogic.github.room.*Dao" />
+        <ignore regexp="io.syslogic.github.room.*Dao"/>
     </issue>
 
     <!-- JaCoCo, from Gradle cache ... -->
     <issue id="InvalidPackage">
-        <ignore regexp="java.lang.instrument" />
-        <ignore regexp="java.lang.management" />
-        <ignore regexp="javax.management" />
+        <ignore regexp="java.lang.instrument"/>
+        <ignore regexp="java.lang.management"/>
+        <ignore regexp="javax.management"/>
     </issue>
 
     <!-- don't notice about available alpha/beta versions -->
diff --git a/mobile/src/main/java/io/syslogic/github/activity/AuthenticatorActivity.java b/mobile/src/main/java/io/syslogic/github/activity/AuthenticatorActivity.java
@@ -40,7 +40,7 @@ public class AuthenticatorActivity extends BaseActivity {
 
     /** Log Tag */
     @SuppressWarnings("unused")
-    private static final String LOG_TAG = AuthenticatorActivity.class.getSimpleName();
+    static final String LOG_TAG = AuthenticatorActivity.class.getSimpleName();
 
     /** layout resId kept for reference */
     @SuppressWarnings("unused")
diff --git a/mobile/src/main/java/io/syslogic/github/activity/NavHostActivity.java b/mobile/src/main/java/io/syslogic/github/activity/NavHostActivity.java
@@ -22,7 +22,7 @@ public class NavHostActivity extends BaseActivity {
 
     /** Log Tag */
     @SuppressWarnings("unused")
-    private static final String LOG_TAG = NavHostActivity.class.getSimpleName();
+    static final String LOG_TAG = NavHostActivity.class.getSimpleName();
 
     /** layout resId kept for reference */
     @SuppressWarnings("unused")
diff --git a/mobile/src/main/java/io/syslogic/github/content/RepositorySyncAdapter.java b/mobile/src/main/java/io/syslogic/github/content/RepositorySyncAdapter.java
@@ -40,8 +40,7 @@
 public class RepositorySyncAdapter extends AbstractThreadedSyncAdapter {
 
     /** Log Tag */
-    @NonNull
-    private static final String LOG_TAG = RepositorySyncAdapter.class.getSimpleName();
+    @NonNull static final String LOG_TAG = RepositorySyncAdapter.class.getSimpleName();
 
     private final SharedPreferences prefs;
 
diff --git a/mobile/src/main/java/io/syslogic/github/fragment/BaseFragment.java b/mobile/src/main/java/io/syslogic/github/fragment/BaseFragment.java
@@ -47,7 +47,7 @@
 abstract public class BaseFragment extends Fragment implements ConnectivityListener {
 
     /** Log Tag */
-    private final String LOG_TAG = BaseFragment.class.getSimpleName();
+    static final String LOG_TAG = BaseFragment.class.getSimpleName();
 
     /** Debug Output */
     static final boolean mDebug = BuildConfig.DEBUG;
diff --git a/mobile/src/main/java/io/syslogic/github/fragment/RepositoryFragment.java b/mobile/src/main/java/io/syslogic/github/fragment/RepositoryFragment.java
@@ -65,8 +65,7 @@
 public class RepositoryFragment extends BaseFragment implements TokenCallback {
 
     /** Log Tag */
-    @SuppressWarnings("unused")
-    private static final String LOG_TAG = RepositoryFragment.class.getSimpleName();
+    @NonNull static final String LOG_TAG = RepositoryFragment.class.getSimpleName();
 
     /** Layout resource ID kept for reference. */
     @SuppressWarnings("unused") private static final int resId = R.layout.fragment_repository;
diff --git a/mobile/src/main/java/io/syslogic/github/fragment/WorkflowJobsFragment.java b/mobile/src/main/java/io/syslogic/github/fragment/WorkflowJobsFragment.java
@@ -31,7 +31,7 @@
 public class WorkflowJobsFragment extends BaseFragment {
 
     /** Log Tag */
-    @SuppressWarnings("unused") private static final String LOG_TAG = WorkflowJobsFragment.class.getSimpleName();
+    @SuppressWarnings("unused") static final String LOG_TAG = WorkflowJobsFragment.class.getSimpleName();
 
     /** Layout resource ID kept for reference. */
     @SuppressWarnings("unused") private static final int resId = R.layout.fragment_workflow_jobs;
diff --git a/mobile/src/main/java/io/syslogic/github/fragment/WorkflowRunFragment.java b/mobile/src/main/java/io/syslogic/github/fragment/WorkflowRunFragment.java
@@ -31,7 +31,7 @@
 public class WorkflowRunFragment extends BaseFragment {
 
     /** Log Tag */
-    @SuppressWarnings("unused") private static final String LOG_TAG = WorkflowRunFragment.class.getSimpleName();
+    @SuppressWarnings("unused") static final String LOG_TAG = WorkflowRunFragment.class.getSimpleName();
 
     /** Layout resource ID kept for reference. */
     @SuppressWarnings("unused") private static final int resId = R.layout.fragment_workflow_run;
@@ -43,10 +43,10 @@ public class WorkflowRunFragment extends BaseFragment {
     Long repositoryId = -1L;
 
     /** The repository's owner. */
-    private String repositoryOwner;
+    String repositoryOwner;
 
     /** The repository's name. */
-    private String repositoryName;
+    String repositoryName;
 
     /** The workflow run's ID. */
     private Long runId = -1L;
@@ -137,7 +137,7 @@ public void onFailure(@NonNull Call<Repository> call, @NonNull Throwable t) {
         }
     }
 
-    private void getWorkflowRun() {
+    void getWorkflowRun() {
 
         Call<WorkflowRun> api = GithubClient.getWorkflowRun(getAccessToken(), repositoryOwner, repositoryName, getRunId());
         GithubClient.logUrl(LOG_TAG, api);
diff --git a/mobile/src/main/java/io/syslogic/github/fragment/WorkflowRunsFragment.java b/mobile/src/main/java/io/syslogic/github/fragment/WorkflowRunsFragment.java
@@ -31,7 +31,7 @@
 public class WorkflowRunsFragment extends BaseFragment {
 
     /** Log Tag */
-    @SuppressWarnings("unused") private static final String LOG_TAG = WorkflowRunsFragment.class.getSimpleName();
+    @SuppressWarnings("unused") static final String LOG_TAG = WorkflowRunsFragment.class.getSimpleName();
 
     /** Layout resource ID kept for reference. */
     @SuppressWarnings("unused") private static final int resId = R.layout.fragment_workflow_runs;
@@ -43,11 +43,10 @@ public class WorkflowRunsFragment extends BaseFragment {
     Long repositoryId = -1L;
 
     /** The repository's owner. */
-    private String repositoryOwner;
+    String repositoryOwner;
 
     /** The repository's name. */
-    private String repositoryName;
-
+    String repositoryName;
 
     /** Constructor */
     public WorkflowRunsFragment() {}
diff --git a/mobile/src/main/java/io/syslogic/github/fragment/WorkflowsFragment.java b/mobile/src/main/java/io/syslogic/github/fragment/WorkflowsFragment.java
@@ -37,22 +37,22 @@
 public class WorkflowsFragment extends BaseFragment {
 
     /** Log Tag */
-    @SuppressWarnings("unused") private static final String LOG_TAG = WorkflowsFragment.class.getSimpleName();
+    @SuppressWarnings("unused") static final String LOG_TAG = WorkflowsFragment.class.getSimpleName();
 
     /** Layout resource ID kept for reference. */
     @SuppressWarnings("unused") private static final int resId = R.layout.fragment_workflows;
 
     /** Data-Binding */
     FragmentWorkflowsBinding mDataBinding;
 
-    /** The repository's ID. */
-    Long repositoryId = -1L;
-
     /** The repository's owner. */
-    private String repositoryOwner;
+    String repositoryOwner;
 
     /** The repository's name. */
-    private String repositoryName;
+    String repositoryName;
+
+    /** The repository's ID. */
+    Long repositoryId = -1L;
 
     /** Constructor */
     public WorkflowsFragment() {}
diff --git a/mobile/src/main/java/io/syslogic/github/network/TokenHelper.java b/mobile/src/main/java/io/syslogic/github/network/TokenHelper.java
@@ -35,10 +35,10 @@
 public class TokenHelper {
 
     /** {@link Log} Tag */
-    private static final String LOG_TAG = TokenHelper.class.getSimpleName();
+    @NonNull static final String LOG_TAG = TokenHelper.class.getSimpleName();
 
     /** Debug Output */
-    private static final boolean mDebug = BuildConfig.DEBUG;
+    static final boolean mDebug = BuildConfig.DEBUG;
 
     @Nullable
     public static String getAccessToken(@NonNull Context context) {
diff --git a/mobile/src/main/java/io/syslogic/github/recyclerview/RepositoriesAdapter.java b/mobile/src/main/java/io/syslogic/github/recyclerview/RepositoriesAdapter.java
@@ -49,7 +49,7 @@ public class RepositoriesAdapter extends RecyclerView.Adapter<RecyclerView.ViewH
 
     /** Log Tag */
     @NonNull
-    private static final String LOG_TAG = RepositoriesAdapter.class.getSimpleName();
+    static final String LOG_TAG = RepositoriesAdapter.class.getSimpleName();
 
     /** Debug Output */
     static final boolean mDebug = BuildConfig.DEBUG;
@@ -275,6 +275,7 @@ void setTotalItemCount(long value) {
     }
 
     /** Getters */
+    @SuppressWarnings("unused")
     public String getRepositoryType() {
         return this.repositoryType;
     }
diff --git a/mobile/src/main/java/io/syslogic/github/recyclerview/RepositorySearchAdapter.java b/mobile/src/main/java/io/syslogic/github/recyclerview/RepositorySearchAdapter.java
@@ -56,8 +56,7 @@
 public class RepositorySearchAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolder> {
 
     /** Log Tag */
-    @NonNull
-    private static final String LOG_TAG = RepositorySearchAdapter.class.getSimpleName();
+    @NonNull static final String LOG_TAG = RepositorySearchAdapter.class.getSimpleName();
 
     /** Debug Output */
     static final boolean mDebug = BuildConfig.DEBUG;
diff --git a/mobile/src/main/java/io/syslogic/github/recyclerview/WorkflowRunsAdapter.java b/mobile/src/main/java/io/syslogic/github/recyclerview/WorkflowRunsAdapter.java
@@ -41,9 +41,9 @@
 public class WorkflowRunsAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolder> {
 
     /** Log Tag */
-    @NonNull @SuppressWarnings("unused") private static final String LOG_TAG = WorkflowRunsAdapter.class.getSimpleName();
-    private static WeakReference<Context> mContext;
-    private static Long repositoryId;
+    @NonNull static final String LOG_TAG = WorkflowRunsAdapter.class.getSimpleName();
+    static WeakReference<Context> mContext;
+    static Long repositoryId;
     List<WorkflowRun> mItems = new ArrayList<>();
 
     public WorkflowRunsAdapter(@NonNull Context context, @NonNull Long repoId) {
diff --git a/mobile/src/main/java/io/syslogic/github/recyclerview/WorkflowStepsAdapter.java b/mobile/src/main/java/io/syslogic/github/recyclerview/WorkflowStepsAdapter.java
@@ -34,7 +34,7 @@
 public class WorkflowStepsAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolder> {
 
     /** Log Tag */
-    @NonNull @SuppressWarnings("unused") private static final String LOG_TAG = WorkflowStepsAdapter.class.getSimpleName();
+    @NonNull static final String LOG_TAG = WorkflowStepsAdapter.class.getSimpleName();
     private static WeakReference<Context> mContext;
     List<WorkflowStep> mItems = new ArrayList<>();
 
@@ -112,7 +112,7 @@ public void onFailure(@NonNull Call<WorkflowJobsResponse> call, @NonNull Throwab
         });
     }
 
-    private void setItems(@NonNull ArrayList<WorkflowStep> items) {
+    void setItems(@NonNull ArrayList<WorkflowStep> items) {
         this.mItems = items;
     }
 
diff --git a/mobile/src/main/java/io/syslogic/github/recyclerview/WorkflowsAdapter.java b/mobile/src/main/java/io/syslogic/github/recyclerview/WorkflowsAdapter.java
@@ -41,7 +41,7 @@
 public class WorkflowsAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolder> {
 
     /** Log Tag */
-    @NonNull @SuppressWarnings("unused") private static final String LOG_TAG = WorkflowsAdapter.class.getSimpleName();
+    @NonNull static final String LOG_TAG = WorkflowsAdapter.class.getSimpleName();
     static WeakReference<Context> mContext;
     List<Workflow> mItems = new ArrayList<>();
     Long repositoryId;
diff --git a/mobile/src/main/res/layout/cardview_workflow_run.xml b/mobile/src/main/res/layout/cardview_workflow_run.xml
@@ -101,7 +101,7 @@
                 android:text='@{ item.conclusion }'
                 android:textColor="@color/colorText"
                 android:textSize="14sp"
-                tools:text="@string/tools_workflow_run_conclusion"/>
+                tools:text="@string/tools_workflow_conclusion"/>
 
         </androidx.appcompat.widget.LinearLayoutCompat>
 
diff --git a/mobile/src/main/res/layout/cardview_workflow_step.xml b/mobile/src/main/res/layout/cardview_workflow_step.xml
@@ -74,7 +74,7 @@
                 android:text="@{ item.conclusion }"
                 android:textColor="@color/colorText"
                 android:textSize="14sp"
-                tools:text="@string/tools_workflow_step_conclusion"/>
+                tools:text="@string/tools_workflow_conclusion"/>
 
         </androidx.appcompat.widget.LinearLayoutCompat>
 
diff --git a/mobile/src/main/res/values/tools.xml b/mobile/src/main/res/values/tools.xml
@@ -19,26 +19,26 @@
     <string name="tools_github_login">token login</string>
 
     <!-- Cardview Repository -->
-    <string name="tools_workflow_count">1</string>
+    <string name="tools_workflow_count">2</string>
 
     <!-- Toolbar & Cardview Workflow -->
-    <string name="tools_workflow_file_name">android.yml</string>
-    <string name="tools_workflow_name">Gradle</string>
-    <string name="tools_workflow_path">.github/workflows/gradle.yml</string>
+    <string name="tools_workflow_file_name">android-ci.yml</string>
+    <string name="tools_workflow_name">Android CI</string>
+    <string name="tools_workflow_path">.github/workflows/android-ci.yml</string>
     <string name="tools_workflow_state">active</string>
     <string name="tools_workflow_html_url">https://</string>
 
+    <string name="tools_workflow_conclusion">success</string>
+
     <!-- Cardview Workflow Run -->
-    <string name="tools_workflow_run_number">185</string>
+    <string name="tools_workflow_run_number">186</string>
     <string name="tools_workflow_run_name">Gradle</string>
-    <string name="tools_workflow_run_title">AGP 8.1.0</string>
-    <string name="tools_workflow_run_conclusion">success</string>
+    <string name="tools_workflow_run_title">AGP 8.1.1</string>
 
     <!-- Cardview Workflow Step -->
     <string name="tools_workflow_step_number">1</string>
     <string name="tools_workflow_step_name"></string>
     <string name="tools_workflow_step_status"></string>
-    <string name="tools_workflow_step_conclusion">success</string>
 
     <!-- Dialog jgit progress -->
     <string name="tools_task_title">remote: Enumerating objects</string>
