tests: comments added, field names changed.

Author: syslogic

src/CloudFunctions.php

@@ -6,7 +6,6 @@
 use GuzzleHttp\Psr7\Utils;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
-use stdClass;
 
 /**
  * Class CloudFunctions.

tests/SimpleTestCase.php

@@ -8,55 +8,60 @@
 
 /**
  * Class Simple TestCase.
- * It depends on the <code>gcloud</code> command to obtain the project ID.
  *
  * @author Martin Zeitler
  * @version 1.0.0
  */
 class SimpleTestCase extends TestCase {
 
     private static string $project_id;
-    private static string $test_topic;
-    private static string $test_bucket;
+    private static array $json_data;
+    private static string $pubsub_topic;
+    private static string $gcs_bucket;
 
     public static function setUpBeforeClass(): void {
         require_once __DIR__.'/../index.php';
-        self::$project_id = self::get_project_id();
-        self::$test_topic = 'play-notifications';
-        self::$test_bucket = 'gs://php-cloudfunctions';
+        self::$project_id   = self::get_project_id();
+        self::$json_data    = ['data' => uniqid()];
+        self::$pubsub_topic = 'play-notifications';
+        self::$gcs_bucket   = 'gs://php-cloudfunctions';
     }
-
+    
+    /** It depends on the <code>gcloud</code> command to obtain the project ID. */
     private static function get_project_id(): string {
         $stdout = shell_exec('gcloud config get-value project');
         if ($stdout == null) {return 'unknown';}
         else {return $stdout;}
     }
 
+    /** Test: On HTTPS */
     public function test_on_https(): void {
-        $payload = json_encode(['data' => uniqid()]);
+        $payload = json_encode(self::$json_data);
         $request = new ServerRequest('POST', '/', [], $payload);
         $response = CloudFunctions::on_https( $request );
         // $this->assertTrue($response->getReasonPhrase().equals("OK"));
         $this->assertTrue($response->getStatusCode() == 200);
     }
 
+    /** Test: On Pub/Sub Event */
     public function test_on_pubsub(): void {
         CloudFunctions::on_pubsub(new CloudEventImmutable(
             uniqId(), // id
-            '//pubsub.googleapis.com/projects/'.self::$project_id.'/topics/'.self::$test_topic, // source
+            '//pubsub.googleapis.com/projects/'.self::$project_id.'/topics/'.self::$pubsub_topic, // source
             'google.cloud.pubsub.topic.v1.messagePublished', // type
             ['data' => base64_encode('Test')], // data
             'application/json' // data content-type
         ));
         self::assertTrue( true );
     }
 
+    /** Test: On GCS Event */
     public function test_on_gcs(): void {
         CloudFunctions::on_gcs(new CloudEventImmutable(
             uniqId(), // id
             'pubsub.googleapis.com', // source
             'google.storage.object.finalize', [ // type
-                'bucket' => self::$test_bucket,
+                'bucket' => self::$gcs_bucket,
                 'name' => 'test.json',
                 'metageneration' => '',
                 'timeCreated' => time(),