always returning a project_id.

syslogic · syslogic · commit 7c7547b179a1 · 2022-02-04T23:37:07.000+01:00
diff --git a/tests/SimpleTestCase.php b/tests/SimpleTestCase.php
@@ -27,8 +27,10 @@ public static function setUpBeforeClass(): void {
         self::$test_bucket = 'gs://php-cloudfunctions';
     }
 
-    private static function get_project_id() {
-        return shell_exec('gcloud config get-value project');
+    private static function get_project_id(): string {
+        $stdout = shell_exec('gcloud config get-value project');
+        if ($stdout == null) {return 'unknown';}
+        else {return $stdout;}
     }
 
     public function test_on_https(): void {

Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,10 @@ public static function setUpBeforeClass(): void {`
`27`	`27`	`self::$test_bucket = 'gs://php-cloudfunctions';`
`28`	`28`	`}`
`29`	`29`
`30`		`- private static function get_project_id() {`
`31`		`- return shell_exec('gcloud config get-value project');`
	`30`	`+ private static function get_project_id(): string {`
	`31`	`+ $stdout = shell_exec('gcloud config get-value project');`
	`32`	`+ if ($stdout == null) {return 'unknown';}`
	`33`	`+ else {return $stdout;}`
`32`	`34`	`}`
`33`	`35`
`34`	`36`	`public function test_on_https(): void {`