Skip to content

Commit 7ce27f6

Browse files
committed
Cleaned up the code
1 parent 7e19444 commit 7ce27f6

File tree

1 file changed

+5
-35
lines changed

1 file changed

+5
-35
lines changed

days/04-06-collections/Bite 30 Movie Data Analysis.py

Lines changed: 5 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -22,25 +22,6 @@ def get_movies_by_director():
2222
"""Extracts all movies from csv and stores them in a dict,
2323
where keys are directors, and values are a list of movies,
2424
use the defined Movie namedtuple"""
25-
26-
# ""
27-
# Their code:
28-
#
29-
#
30-
# directors = defaultdict(list)
31-
# with open(data, encoding='utf-8') as f:
32-
# for line in csv.DictReader(f):
33-
# try:
34-
# director = line['director_name']
35-
# movie = line['movie_title'].replace('\xa0', '')
36-
# year = int(line['title_year'])
37-
# score = float(line['imdb_score'])
38-
# except ValueError:
39-
# continue
40-
#
41-
# m = Movie(title=movie, year=year, score=score)
42-
# directors[director].append(m)
43-
# ""
4425
movies = defaultdict(list)
4526
input_file = csv.DictReader(open(f"/tmp/{fname}"))
4627
for row in input_file:
@@ -53,7 +34,6 @@ def get_movies_by_director():
5334
return movies
5435

5536

56-
5737
def calc_mean_score(movies):
5838
"""Helper method to calculate mean of list of Movie namedtuples,
5939
round the mean to 1 decimal place"""
@@ -80,30 +60,20 @@ def get_average_scores(directors):
8060
if len(directors[director]) < 4:
8161
director_del.append(director)
8262

83-
for dir in director_del:
84-
del directors[dir]
85-
86-
returnValue = []
63+
for direct in director_del:
64+
del directors[direct]
8765

88-
# for director, movies in directors.items():
89-
# total = 0
90-
# count = 0
91-
# for mov in movies:
92-
# total = total + float(mov.score[1])
93-
# count = count + 1
94-
# returnValue.append((director, round((total / count), 1)))
66+
return_value = []
9567

9668
for director, movies in directors.items():
97-
returnValue.append(
69+
return_value.append(
9870
(
9971
director,
10072
round((sum([float(mov.score[1]) for mov in movies]) / len(movies)) , 1)
10173
)
10274
)
10375

104-
return sorted(returnValue, key=lambda x: x[1], reverse=True)
105-
106-
76+
return sorted(return_value, key=lambda x: x[1], reverse=True)
10777

10878

10979
director_movies = get_movies_by_director()

0 commit comments

Comments
 (0)