Skip to content

Commit 0de0349

Browse files
committed
another fix for axis confusion
1 parent ebff53e commit 0de0349

File tree

2 files changed

+26
-26
lines changed

2 files changed

+26
-26
lines changed

plotly/tests/test_optional/test_opt_tracefactory.py

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,9 @@ def test_default_dendrogram(self):
136136
'x': np.array([5., 5., 22.5, 22.5]),
137137
'type': u'scatter'}]
138138
expected_layout = {'width': '100%',
139-
'showlegend': False,
140-
'autoscale': False,
141-
'x': {'showticklabels': True,
139+
'showlegend': False,
140+
'autoscale': False,
141+
'xaxis': {'showticklabels': True,
142142
'tickmode': 'array',
143143
'ticks': 'outside',
144144
'showgrid': False,
@@ -152,15 +152,15 @@ def test_default_dendrogram(self):
152152
'type': 'linear',
153153
'tickvals': np.array([5.0, 15.0,
154154
25.0, 35.0])},
155-
'y': {'showticklabels': True,
156-
'ticks': 'outside',
157-
'showgrid': False,
158-
'mirror': 'allticks',
159-
'zeroline': False,
160-
'showline': True,
161-
'rangemode': 'tozero',
162-
'type': 'linear'},
163-
'hovermode': 'closest'}
155+
'yaxis': {'showticklabels': True,
156+
'ticks': 'outside',
157+
'showgrid': False,
158+
'mirror': 'allticks',
159+
'zeroline': False,
160+
'showline': True,
161+
'rangemode': 'tozero',
162+
'type': 'linear'},
163+
'hovermode': 'closest'}
164164

165165
# Make sure data is as expected
166166
self.assertEqual(len(dendro['data']), len(expected_data))
@@ -171,12 +171,12 @@ def test_default_dendrogram(self):
171171
expected_data[i]['y']))
172172

173173
# Make sure layout is as expected
174-
self.assertTrue(np.array_equal(dendro['layout']['x']['ticktext'],
175-
expected_layout['x']['ticktext']))
176-
self.assertTrue(np.array_equal(dendro['layout']['x']['tickvals'],
177-
expected_layout['x']['tickvals']))
178-
self.assertEqual(dendro['layout']['x']['ticks'], 'outside')
179-
self.assertEqual(dendro['layout']['y']['ticks'], 'outside')
174+
self.assertTrue(np.array_equal(dendro['layout']['xaxis']['ticktext'],
175+
expected_layout['xaxis']['ticktext']))
176+
self.assertTrue(np.array_equal(dendro['layout']['xaxis']['tickvals'],
177+
expected_layout['xaxis']['tickvals']))
178+
self.assertEqual(dendro['layout']['xaxis']['ticks'], 'outside')
179+
self.assertEqual(dendro['layout']['yaxis']['ticks'], 'outside')
180180
self.assertEqual(dendro['layout']['width'], expected_layout['width'])
181181

182182
def test_dendrogram_random_matrix(self):
@@ -189,28 +189,28 @@ def test_dendrogram_random_matrix(self):
189189
dendro = tls.FigureFactory.create_dendrogram(X, labels=names)
190190

191191
# Check that 2 is in a separate cluster and it's labelled correctly
192-
self.assertEqual(dendro['layout']['x']['ticktext'][0], 'John')
192+
self.assertEqual(dendro['layout']['xaxis']['ticktext'][0], 'John')
193193

194194
def test_dendrogram_orientation(self):
195195
X = np.random.rand(5, 5)
196196

197197
dendro_left = tls.FigureFactory.create_dendrogram(X, orientation='left')
198198

199-
self.assertEqual(len(dendro_left['layout']['y']['ticktext']), 5)
200-
tickvals_left = np.array(dendro_left['layout']['y']['tickvals'])
199+
self.assertEqual(len(dendro_left['layout']['yaxis']['ticktext']), 5)
200+
tickvals_left = np.array(dendro_left['layout']['yaxis']['tickvals'])
201201
self.assertTrue((tickvals_left <= 0).all())
202202

203203
dendro_right = tls.FigureFactory.create_dendrogram(X, orientation='right')
204-
tickvals_right = np.array(dendro_right['layout']['y']['tickvals'])
204+
tickvals_right = np.array(dendro_right['layout']['yaxis']['tickvals'])
205205
self.assertTrue((tickvals_right >= 0).all())
206206

207207
dendro_bottom = tls.FigureFactory.create_dendrogram(X, orientation='bottom')
208-
self.assertEqual(len(dendro_bottom['layout']['x']['ticktext']), 5)
209-
tickvals_bottom = np.array(dendro_bottom['layout']['x']['tickvals'])
208+
self.assertEqual(len(dendro_bottom['layout']['xaxis']['ticktext']), 5)
209+
tickvals_bottom = np.array(dendro_bottom['layout']['xaxis']['tickvals'])
210210
self.assertTrue((tickvals_bottom >= 0).all())
211211

212212
dendro_top = tls.FigureFactory.create_dendrogram(X, orientation='top')
213-
tickvals_top = np.array(dendro_top['layout']['x']['tickvals'])
213+
tickvals_top = np.array(dendro_top['layout']['xaxis']['tickvals'])
214214
self.assertTrue((tickvals_top <= 0).all())
215215

216216

plotly/tools.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2952,7 +2952,7 @@ class _Dendrogram(FigureFactory):
29522952
"""
29532953

29542954
def __init__(self, X, orientation='bottom', labels=None, colorscale=None,
2955-
width="100%", height="100%", xaxis='x', yaxis='y'):
2955+
width="100%", height="100%", xaxis='xaxis', yaxis='yaxis'):
29562956
self.orientation = orientation
29572957
self.labels = labels
29582958
self.xaxis = xaxis

0 commit comments

Comments
 (0)