Skip to content

Commit c54f643

Browse files
committed
Expect Infinity/NaN —> null in tests now.
1 parent f5df133 commit c54f643

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

plotly/tests/test_optional/test_utils/test_utils.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ def test_column_json_encoding():
173173
'"2014-01-05 01:01:01", '
174174
'"2014-01-05 01:01:01.000001"], '
175175
'"name": "col 2"}, '
176-
'{"data": [1, 2, 3, NaN, NaN, Infinity, '
176+
'{"data": [1, 2, 3, null, null, null, '
177177
'"2014-01-05"], "name": "col 3"}]' == json_columns)
178178

179179

@@ -188,7 +188,7 @@ def test_figure_json_encoding():
188188
js2 = json.dumps(s2, cls=utils.PlotlyJSONEncoder, sort_keys=True)
189189

190190
assert(js1 == '{"type": "scatter3d", "x": [1, 2, 3], '
191-
'"y": [1, 2, 3, NaN, NaN, Infinity, "2014-01-05"], '
191+
'"y": [1, 2, 3, null, null, null, "2014-01-05"], '
192192
'"z": [1, "A", "2014-01-05", '
193193
'"2014-01-05 01:01:01", "2014-01-05 01:01:01.000001"]}')
194194
assert(js2 == '{"type": "scatter", "x": [1, 2, 3]}')
@@ -219,7 +219,7 @@ def test_datetime_json_encoding():
219219

220220
def test_pandas_json_encoding():
221221
j1 = json.dumps(df['col 1'], cls=utils.PlotlyJSONEncoder)
222-
assert(j1 == '[1, 2, 3, "2014-01-05", null, NaN, Infinity]')
222+
assert(j1 == '[1, 2, 3, "2014-01-05", null, null, null]')
223223

224224
# Test that data wasn't mutated
225225
assert_series_equal(df['col 1'],
@@ -249,7 +249,7 @@ def test_numpy_masked_json_encoding():
249249
l = [1, 2, np.ma.core.masked]
250250
j1 = json.dumps(l, cls=utils.PlotlyJSONEncoder)
251251
print j1
252-
assert(j1 == '[1, 2, NaN]')
252+
assert(j1 == '[1, 2, null]')
253253
assert(set(l) == set([1, 2, np.ma.core.masked]))
254254

255255

@@ -276,7 +276,7 @@ def test_masked_constants_example():
276276
jy = json.dumps(renderer.plotly_fig['data'][1]['y'],
277277
cls=utils.PlotlyJSONEncoder)
278278
assert(jy == '[-398.11793026999999, -398.11792966000002, '
279-
'-398.11786308000001, NaN]')
279+
'-398.11786308000001, null]')
280280

281281

282282
def test_numpy_dates():

0 commit comments

Comments
 (0)