Merge pull request github#2086 from calumgrant/cs/indexer-detection

hvitved · web-flow · commit 3f170142c9f0 · 2019-10-15T15:33:32.000+02:00
C#: Fix an InvalidCastException
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Property.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Property.cs
@@ -111,7 +111,7 @@ public override Microsoft.CodeAnalysis.Location FullLocation
 
         public static Property Create(Context cx, IPropertySymbol prop)
         {
-            bool isIndexer = prop.IsIndexer || prop.ExplicitInterfaceImplementations.Any(e => e.IsIndexer);
+            bool isIndexer = prop.IsIndexer || prop.Parameters.Any();
 
             return isIndexer ? Indexer.Create(cx, prop) : PropertyFactory.Instance.CreateEntity(cx, prop);
         }

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ public override Microsoft.CodeAnalysis.Location FullLocation`
`111`	`111`
`112`	`112`	`public static Property Create(Context cx, IPropertySymbol prop)`
`113`	`113`	`{`
`114`		`- bool isIndexer = prop.IsIndexer \|\| prop.ExplicitInterfaceImplementations.Any(e => e.IsIndexer);`
	`114`	`+ bool isIndexer = prop.IsIndexer \|\| prop.Parameters.Any();`
`115`	`115`
`116`	`116`	`return isIndexer ? Indexer.Create(cx, prop) : PropertyFactory.Instance.CreateEntity(cx, prop);`
`117`	`117`	`}`