JS: Add another warning

asgerf · asgerf · commit 4ca3ac5ee9e7 · 2020-04-08T10:30:45.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/AMD.qll b/javascript/ql/src/semmle/javascript/AMD.qll
@@ -61,6 +61,7 @@ class AmdModuleDefinition extends CallExpr {
   }
 
   private DataFlow::Node getFactoryNodeInternal() {
+    // To avoid recursion, this should not depend on `SourceNode`.
     result = DataFlow::valueNode(getLastArgument()) or
     result = getFactoryNodeInternal().getAPredecessor()
   }

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,7 @@ class AmdModuleDefinition extends CallExpr {`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`private DataFlow::Node getFactoryNodeInternal() {`
	`64`	+ // To avoid recursion, this should not depend on `SourceNode`.
`64`	`65`	`result = DataFlow::valueNode(getLastArgument()) or`
`65`	`66`	`result = getFactoryNodeInternal().getAPredecessor()`
`66`	`67`	`}`